Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: sky/engine/bindings/core/v8/CustomElementConstructorBuilder.cpp

Issue 885713004: Remove CustomElementDescriptor. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/core.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/CustomElementConstructorBuilder.cpp
diff --git a/sky/engine/bindings/core/v8/CustomElementConstructorBuilder.cpp b/sky/engine/bindings/core/v8/CustomElementConstructorBuilder.cpp
index bb001a07d0f996e3c9541bbf01d69b8fa4e64394..af8377911ed959ab7a599c376834e1f92005be11 100644
--- a/sky/engine/bindings/core/v8/CustomElementConstructorBuilder.cpp
+++ b/sky/engine/bindings/core/v8/CustomElementConstructorBuilder.cpp
@@ -42,7 +42,6 @@
#include "sky/engine/bindings/core/v8/V8PerContextData.h"
#include "sky/engine/core/dom/Document.h"
#include "sky/engine/core/dom/custom/CustomElementDefinition.h"
-#include "sky/engine/core/dom/custom/CustomElementDescriptor.h"
#include "sky/engine/core/dom/custom/CustomElementException.h"
#include "sky/engine/core/dom/custom/CustomElementProcessingStack.h"
#include "sky/engine/wtf/Assertions.h"
@@ -166,20 +165,18 @@ bool CustomElementConstructorBuilder::createConstructor(Document* document, Cust
v8::Isolate* isolate = m_scriptState->isolate();
- if (!prototypeIsValid(definition->descriptor().localName(), exceptionState))
+ if (!prototypeIsValid(definition->localName(), exceptionState))
return false;
v8::Local<v8::FunctionTemplate> constructorTemplate = v8::FunctionTemplate::New(isolate);
constructorTemplate->SetCallHandler(constructCustomElement);
m_constructor = constructorTemplate->GetFunction();
if (m_constructor.IsEmpty()) {
- CustomElementException::throwException(CustomElementException::ContextDestroyedRegisteringDefinition, definition->descriptor().localName(), exceptionState);
+ CustomElementException::throwException(CustomElementException::ContextDestroyedRegisteringDefinition, definition->localName(), exceptionState);
return false;
}
- const CustomElementDescriptor& descriptor = definition->descriptor();
-
- v8::Handle<v8::String> v8TagName = v8String(isolate, descriptor.localName());
+ v8::Handle<v8::String> v8TagName = v8String(isolate, definition->localName());
m_constructor->SetName(v8TagName);
« no previous file with comments | « no previous file | sky/engine/core/core.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698