Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: sky/engine/core/dom/custom/CustomElementRegistry.cpp

Issue 885713004: Remove CustomElementDescriptor. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/dom/custom/CustomElementRegistry.cpp
diff --git a/sky/engine/core/dom/custom/CustomElementRegistry.cpp b/sky/engine/core/dom/custom/CustomElementRegistry.cpp
index 7302c62237d6c7c97750c4b1325d02763197323d..0c10a897224ff0b27e9b8f0c8ad9bd9ddeef6a94 100644
--- a/sky/engine/core/dom/custom/CustomElementRegistry.cpp
+++ b/sky/engine/core/dom/custom/CustomElementRegistry.cpp
@@ -94,13 +94,12 @@ CustomElementDefinition* CustomElementRegistry::registerElement(Document* docume
return 0;
}
- const CustomElementDescriptor descriptor(tagName.localName());
- RefPtr<CustomElementDefinition> definition = CustomElementDefinition::create(descriptor, lifecycleCallbacks);
+ RefPtr<CustomElementDefinition> definition = CustomElementDefinition::create(tagName.localName(), lifecycleCallbacks);
if (!constructorBuilder->createConstructor(document, definition.get(), exceptionState))
return 0;
- m_definitions.add(descriptor, definition);
+ m_definitions.add(tagName.localName(), definition);
if (!constructorBuilder->didRegisterDefinition(definition.get())) {
CustomElementException::throwException(CustomElementException::ContextDestroyedRegisteringDefinition, type, exceptionState);
@@ -110,9 +109,9 @@ CustomElementDefinition* CustomElementRegistry::registerElement(Document* docume
return definition.get();
}
-CustomElementDefinition* CustomElementRegistry::find(const CustomElementDescriptor& descriptor) const
+CustomElementDefinition* CustomElementRegistry::find(const AtomicString& localName) const
{
- return m_definitions.get(descriptor);
+ return m_definitions.get(localName);
}
} // namespace blink
« no previous file with comments | « sky/engine/core/dom/custom/CustomElementRegistry.h ('k') | sky/engine/core/dom/custom/CustomElementScheduler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698