Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Issue 88563003: DM: add --tileGrid (Closed)

Created:
7 years ago by mtklein
Modified:
7 years ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : diffbase onto 88543002 #

Patch Set 3 : rebase to head #

Patch Set 4 : undo pointless move #

Total comments: 4

Patch Set 5 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -5 lines) Patch
M dm/DMCpuTask.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M dm/DMReplayTask.h View 1 chunk +2 lines, -2 lines 0 comments Download
A dm/DMTileGridTask.h View 1 chunk +36 lines, -0 lines 0 comments Download
A dm/DMTileGridTask.cpp View 1 2 3 4 1 chunk +77 lines, -0 lines 0 comments Download
M dm/README View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/dm.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
7 years ago (2013-11-26 20:52:20 UTC) #1
epoger
LGTM if you make the following changes (I'll be out until Dec 3, so if ...
7 years ago (2013-11-26 22:26:00 UTC) #2
mtklein
Thanks Elliot. https://codereview.chromium.org/88563003/diff/60001/dm/DMTileGridTask.cpp File dm/DMTileGridTask.cpp (right): https://codereview.chromium.org/88563003/diff/60001/dm/DMTileGridTask.cpp#newcode9 dm/DMTileGridTask.cpp:9: // Tile grid tests are currently failing. ...
7 years ago (2013-11-26 23:34:34 UTC) #3
mtklein
7 years ago (2013-11-26 23:36:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r12408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698