Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 885373004: Use customization mode by default in permission bubbles (Closed)

Created:
5 years, 10 months ago by felt
Modified:
5 years, 10 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use customization mode by default in permission bubbles Previously: when multiple permissions were requested, they could only be toggled individually if the user clicked on "Customize." Now: the bubble will always allow for customization if there are multiple permissions in the request. it will be the default state. BUG=440563 Committed: https://crrev.com/2a9817f644de5d1859e2b029971bef5f29aea90f Cr-Commit-Position: refs/heads/master@{#314731}

Patch Set 1 #

Patch Set 2 : Test fixes etc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -239 lines) Patch
M chrome/browser/download/download_request_limiter_unittest.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h View 1 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 11 chunks +23 lines, -58 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm View 1 6 chunks +58 lines, -61 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 12 chunks +14 lines, -86 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_manager.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_manager.cc View 3 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_view.h View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
felt
Markus, can you please review: chrome/browser/ui/website_settings/* chrome/browser/ui/views/website_settings/*
5 years, 10 months ago (2015-01-31 15:53:07 UTC) #7
markusheintz_
LGTM It would be great if you could attach some before and after screenshots. That ...
5 years, 10 months ago (2015-02-02 08:54:16 UTC) #8
felt
On 2015/02/02 08:54:16, markusheintz_ wrote: > LGTM > > It would be great if you ...
5 years, 10 months ago (2015-02-02 12:19:29 UTC) #9
felt
groby@, can you please review c/b/ui/cocoa/*? asanka@, can you please review c/b/download/download_request_limiter_unittest.cc?
5 years, 10 months ago (2015-02-02 12:32:03 UTC) #12
asanka
c/b/download/ lgtm
5 years, 10 months ago (2015-02-02 14:48:32 UTC) #13
felt
groby, friendly ping
5 years, 10 months ago (2015-02-04 08:09:18 UTC) #14
groby-ooo-7-16
c/b/ui/cocoa lgtm
5 years, 10 months ago (2015-02-04 22:17:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885373004/120001
5 years, 10 months ago (2015-02-05 01:52:56 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:120001)
5 years, 10 months ago (2015-02-05 03:13:40 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 03:14:25 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a9817f644de5d1859e2b029971bef5f29aea90f
Cr-Commit-Position: refs/heads/master@{#314731}

Powered by Google App Engine
This is Rietveld 408576698