chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm - Issue 885373004: Use customization mode by default in permission bubbles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

Issue 885373004: Use customization mode by default in permission bubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test fixes etc. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

index 4370ec25fa348a916f2491e0636a370d3cb08fa5..df581a4b8370ac5b67fd83fabcb07ac6d89975d8 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm

@@ -21,8 +21,7 @@ PermissionBubbleCocoa::~PermissionBubbleCocoa() {

void PermissionBubbleCocoa::Show(

const std::vector<PermissionBubbleRequest*>& requests,

- const std::vector<bool>& accept_state,

- bool customization_mode) {

+ const std::vector<bool>& accept_state) {

DCHECK(parent_window_);

if (!bubbleController_) {

@@ -34,8 +33,7 @@ void PermissionBubbleCocoa::Show(

[bubbleController_ showAtAnchor:GetAnchorPoint()

withDelegate:delegate_

forRequests:requests

- acceptStates:accept_state

- customizationMode:customization_mode];

+ acceptStates:accept_state];

}

void PermissionBubbleCocoa::Hide() {