chrome/browser/ui/website_settings/permission_bubble_view.h - Issue 885373004: Use customization mode by default in permission bubbles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_view.h

Issue 885373004: Use customization mode by default in permission bubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test fixes etc. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/website_settings/permission_bubble_view.h

diff --git a/chrome/browser/ui/website_settings/permission_bubble_view.h b/chrome/browser/ui/website_settings/permission_bubble_view.h

index 669c997969e8a45a19d088b165f9e91fc4e46348..6c3447411d5d10f2d7660eb86924a1761d1369af 100644

--- a/chrome/browser/ui/website_settings/permission_bubble_view.h

+++ b/chrome/browser/ui/website_settings/permission_bubble_view.h

@@ -23,7 +23,6 @@ class PermissionBubbleView {

virtual ~Delegate() {}

virtual void ToggleAccept(int index, bool new_value) = 0;

- virtual void SetCustomizationMode() = 0;

virtual void Accept() = 0;

virtual void Deny() = 0;

virtual void Closing() = 0;

@@ -43,8 +42,7 @@ class PermissionBubbleView {

// in this call.

virtual void Show(

const std::vector<PermissionBubbleRequest*>& requests,

- const std::vector<bool>& accept_state,

- bool customization_mode) = 0;

+ const std::vector<bool>& accept_state) = 0;

// Returns true if the view can accept a new Show() command to coalesce

// requests. Currently the policy is that this should return true if the view

« no previous file with comments | « chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc ('k') | no next file » | no next file with comments »