chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h - Issue 885373004: Use customization mode by default in permission bubbles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

Issue 885373004: Use customization mode by default in permission bubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test fixes etc. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm ('k') | chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

index 3ec26c4aae6ac774e1fe957c1dcbdcf50242a3b8..ce4146268943c3d19ef964dc7d2143671b71b470 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h

@@ -17,7 +17,7 @@ class PermissionBubbleRequest;

BaseBubbleController<NSTextViewDelegate> {

@private

// Array of views that are the checkboxes for every requested permission.

- // Only populated if |customizationMode| is YES when the UI is shown.

+ // Only populated if multiple requests are shown at once.

base::scoped_nsobject<NSMutableArray> checkboxes_;

// Delegate to be informed of user actions.

@@ -43,10 +43,6 @@ class PermissionBubbleRequest;

- (void)showAtAnchor:(NSPoint)anchor

withDelegate:(PermissionBubbleView::Delegate*)delegate

forRequests:(const std::vector<PermissionBubbleRequest*>&)requests

- acceptStates:(const std::vector<bool>&)acceptStates

- customizationMode:(BOOL)customizationMode;

-// Called when a menu item is selected.

-- (void)onMenuItemClicked:(int)commandId;

+ acceptStates:(const std::vector<bool>&)acceptStates;

@end