[autofill] Show autofill popup when focusing a field by tapping near its edge.

[autofill] Show autofill popup when tapping near input's edge.

Tapping near the edge of an input field focuses the field, but does not
bring up the autofill popup. The issue is taking the tap width into
account when handling field focus, but not when checking which element
was tapped. The fix is to take the tap width and height into account
when checking which field was tapped.

This is the Chrome part of the fix. The Blink part is:
http://crrev.com/913323004

BUG=430318
Committed: https://crrev.com/881f5a7ee33a647fcf8db0b1e5210b700bb01a45
Cr-Commit-Position: refs/heads/master@{#316602}

[please use gerrit instead, 2015-01-28 22:43:40]

rouslan@chromium.org changed reviewers:
+ estade@chromium.org

[please use gerrit instead, 2015-01-28 22:43:41]

Evan, PTAL.

Is it reasonable to add a method to render_view_test.cc here? (I assume
render_view_test.cc will go away soon.)

https://codereview.chromium.org/884583002/diff/20001/content/public/test/rend...
File content/public/test/render_view_test.cc (right):

https://codereview.chromium.org/884583002/diff/20001/content/public/test/rend...
content/public/test/render_view_test.cc:356: impl->FocusChangeComplete();
I haven't figured out how to trigger FocusChangeComplete() when issuing
WebGestureEvents on non-Android platforms.

[Evan Stade, 2015-01-28 23:56:22]

Does this /guarantee/ that focus and activation will be mutually implicative?

[Evan Stade, 2015-01-28 23:56:23]

Does this /guarantee/ that focus and activation will be mutually implicative?

[Evan Stade, 2015-01-28 23:57:06]

On 2015/01/28 23:56:23, Evan Stade wrote:
> Does this /guarantee/ that focus and activation will be mutually implicative?

I ask, because what would make me feel more comfortable, is some hittest call
into blink, which is the same hittest blink is using for focus change.

[Evan Stade, 2015-01-28 23:57:33]

On 2015/01/28 23:57:06, Evan Stade wrote:
> On 2015/01/28 23:56:23, Evan Stade wrote:
> > Does this /guarantee/ that focus and activation will be mutually
implicative?
> 
> I ask, because what would make me feel more comfortable, is some hittest call
> into blink, which is the same hittest blink is using for focus change.

wow too many commas

[please use gerrit instead, 2015-01-28 23:59:49]

On 2015/01/28 23:56:23, Evan Stade wrote:
> Does this /guarantee/ that focus and activation will be mutually implicative?

This patch does not guarantee the mutual implication, because activation check
does not use the same code as focus check. That would require blink changes.
Would you prefer that approach instead?

[please use gerrit instead, 2015-01-29 00:01:54]

On 2015/01/28 23:57:06, Evan Stade wrote:
> On 2015/01/28 23:56:23, Evan Stade wrote:
> > Does this /guarantee/ that focus and activation will be mutually
implicative?
> 
> I ask, because what would make me feel more comfortable, is some hittest call
> into blink, which is the same hittest blink is using for focus change.

Ok, let me cook that up.

[Evan Stade, 2015-01-29 00:34:04]

https://codereview.chromium.org/884583002/diff/20001/components/autofill/cont...
File components/autofill/content/renderer/page_click_tracker.cc (right):

https://codereview.chromium.org/884583002/diff/20001/components/autofill/cont...
components/autofill/content/renderer/page_click_tracker.cc:95: void
PageClickTracker::FocusChangeComplete() {
also please change the name of this

[please use gerrit instead, 2015-01-29 01:47:04]

https://codereview.chromium.org/884583002/diff/20001/components/autofill/cont...
File components/autofill/content/renderer/page_click_tracker.cc (right):

https://codereview.chromium.org/884583002/diff/20001/components/autofill/cont...
components/autofill/content/renderer/page_click_tracker.cc:95: void
PageClickTracker::FocusChangeComplete() {
On 2015/01/29 00:34:04, Evan Stade wrote:
> also please change the name of this

https://codereview.chromium.org/886663002/

[please use gerrit instead, 2015-02-03 00:29:57]

Patchset #3 (id:40001) has been deleted

[please use gerrit instead, 2015-02-03 00:32:00]

Evan, PTAL Patch Set 3.

[please use gerrit instead, 2015-02-04 01:10:22]

Please don't review. The fix for the browser tests may be involved.

[please use gerrit instead, 2015-02-12 18:34:03]

Patchset #3 (id:60001) has been deleted

[please use gerrit instead, 2015-02-12 18:34:09]

Patchset #3 (id:80001) has been deleted

[please use gerrit instead, 2015-02-12 18:35:59]

Evan, PTAL Patch Set 3.

It's ready for review. The newly added browser tests will be failing until
http://crrev.com/913323004 lands and new revision of Blink rolls into Chrome.

[Evan Stade, 2015-02-13 00:01:17]

lgtm

[please use gerrit instead, 2015-02-13 21:22:01]

rouslan@chromium.org changed reviewers:
+ jcivelli@chromium.org

[please use gerrit instead, 2015-02-13 21:22:02]

Jay, OWNERS PTAL content/public/test/render_view_test.* in Patch Set 3.

[Jay Civelli, 2015-02-13 21:31:07]

LGTM for content/public/test

[please use gerrit instead, 2015-02-13 21:43:00]

Waiting for Blink roll that fixes the new browser_test...

[please use gerrit instead, 2015-02-16 18:33:43]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2015-02-16 18:34:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/884583002/100001

[commit-bot: I haz the power, 2015-02-16 20:14:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-16 20:14:44]

Try jobs failed on following builders:
  android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...)

[please use gerrit instead, 2015-02-17 16:18:04]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2015-02-17 16:19:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/884583002/100001

[commit-bot: I haz the power, 2015-02-17 17:52:33]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2015-02-17 17:53:18]

Patchset 3 (id:??) landed as
https://crrev.com/881f5a7ee33a647fcf8db0b1e5210b700bb01a45
Cr-Commit-Position: refs/heads/master@{#316602}