[autofill] Show autofill popup when focusing a field by tapping near its edge.

components/autofill/content/renderer/page_click_tracker.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/page_click_tracker.h"
 
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/content/renderer/page_click_listener.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_view.h"
+#include "third_party/WebKit/public/platform/WebPoint.h"
+#include "third_party/WebKit/public/platform/WebSize.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
+#include "third_party/WebKit/public/web/WebHitTestResult.h"
 #include "third_party/WebKit/public/web/WebInputElement.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebTextAreaElement.h"
 #include "third_party/WebKit/public/web/WebView.h"
 
 using blink::WebElement;
 using blink::WebGestureEvent;
 using blink::WebInputElement;
 using blink::WebInputEvent;
 using blink::WebMouseEvent;
 using blink::WebNode;
+using blink::WebPoint;
+using blink::WebSize;
 using blink::WebTextAreaElement;
 
 namespace {
 
 // Casts |node| to a WebInputElement.
 // Returns an empty (isNull()) WebInputElement if |node| is not a text field.
 const WebInputElement GetTextWebInputElement(const WebNode& node) {
   if (!node.isElementNode())
     return WebInputElement();
   const WebElement element = node.toConst<WebElement>();
@@ skipping 32 matching lines @@
 
 PageClickTracker::~PageClickTracker() {
 }
 
 void PageClickTracker::DidHandleMouseEvent(const WebMouseEvent& event) {
   if (event.type != WebInputEvent::MouseDown ||
       event.button != WebMouseEvent::ButtonLeft) {
     return;
   }
 
-  PotentialActivationAt(event.x, event.y);
+  WebNode clicked_node = render_frame()->GetRenderView()->GetWebView()
+      ->hitTestResultAt(WebPoint(event.x, event.y)).node();
+  focused_node_was_last_clicked_ = !clicked_node.isNull() &&
+                                   clicked_node.focused();
 }
 
 void PageClickTracker::DidHandleGestureEvent(const WebGestureEvent& event) {
   if (event.type != WebGestureEvent::GestureTap)
     return;
 
-  PotentialActivationAt(event.x, event.y);
+  WebNode tapped_node = render_frame()->GetRenderView()->GetWebView()
+      ->hitTestResultForTap(
+          WebPoint(event.x, event.y),
+          WebSize(event.data.tap.width, event.data.tap.height)).node();
+  focused_node_was_last_clicked_ = !tapped_node.isNull() &&
+                                   tapped_node.focused();
 }
 
 void PageClickTracker::FocusedNodeChanged(const WebNode& node) {
   was_focused_before_now_ = false;
 }
 
 void PageClickTracker::FocusChangeComplete() {
-  blink::WebNode focused_node = render_frame()->GetFocusedElement();
+  WebNode focused_node = render_frame()->GetFocusedElement();
   if (focused_node_was_last_clicked_ && !focused_node.isNull()) {
     const WebInputElement input_element = GetTextWebInputElement(focused_node);
     if (!input_element.isNull()) {
       listener_->FormControlElementClicked(input_element,
                                            was_focused_before_now_);
     } else {
       const WebTextAreaElement textarea_element =
           GetWebTextAreaElement(focused_node);
       if (!textarea_element.isNull()) {
         listener_->FormControlElementClicked(textarea_element,
                                              was_focused_before_now_);
       }
     }
   }
 
   was_focused_before_now_ = true;
   focused_node_was_last_clicked_ = false;
 }
 
-void PageClickTracker::PotentialActivationAt(int x, int y) {
-  blink::WebElement focused_element = render_frame()->GetFocusedElement();
-  if (focused_element.isNull())
-    return;
-
-  if (!GetScaledBoundingBox(
-           render_frame()->GetRenderView()->GetWebView()->pageScaleFactor(),
-           &focused_element).Contains(x, y)) {
-    return;
-  }
-
-  focused_node_was_last_clicked_ = true;
-}
-
 // PageClickTracker::Legacy ----------------------------------------------------
 
 PageClickTracker::Legacy::Legacy(PageClickTracker* tracker)
     : content::RenderViewObserver(tracker->render_frame()->GetRenderView()),
       tracker_(tracker) {
 }
 
 void PageClickTracker::Legacy::OnDestruct() {
   // No-op. Don't delete |this|.
 }
 
-void PageClickTracker::Legacy::DidHandleMouseEvent(
-    const blink::WebMouseEvent& event) {
+void PageClickTracker::Legacy::DidHandleMouseEvent(const WebMouseEvent& event) {
   tracker_->DidHandleMouseEvent(event);
 }
 
 void PageClickTracker::Legacy::DidHandleGestureEvent(
-    const blink::WebGestureEvent& event) {
+    const WebGestureEvent& event) {
   tracker_->DidHandleGestureEvent(event);
 }
 
 void PageClickTracker::Legacy::FocusChangeComplete() {
   tracker_->FocusChangeComplete();
 }
 
 }  // namespace autofill