components/autofill/content/renderer/page_click_tracker.h - Issue 884583002: [autofill] Show autofill popup when focusing a field by tapping near its edge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/page_click_tracker.h

Issue 884583002: [autofill] Show autofill popup when focusing a field by tapping near its edge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bounds-change

Patch Set: Use Blink hit testing Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/page_click_tracker_browsertest.cc ('k') | components/autofill/content/renderer/page_click_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/page_click_tracker.h

diff --git a/components/autofill/content/renderer/page_click_tracker.h b/components/autofill/content/renderer/page_click_tracker.h

index 08e19abb43fdb710d9061117de4b95b759e47404..41b163d729e85aca1f81087f242ad362893d1c78 100644

--- a/components/autofill/content/renderer/page_click_tracker.h

+++ b/components/autofill/content/renderer/page_click_tracker.h

@@ -60,9 +60,6 @@ class PageClickTracker : public content::RenderFrameObserver {

void DidHandleGestureEvent(const blink::WebGestureEvent& event);

void FocusChangeComplete();

- // Called there is a tap or click at |x|, |y|.

- void PotentialActivationAt(int x, int y);

// True when the last click was on the focused node.

bool focused_node_was_last_clicked_;