[autofill] Show autofill popup when focusing a field by tapping near its edge.

components/autofill/content/renderer/page_click_tracker.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/page_click_tracker.h"
 
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/content/renderer/page_click_listener.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebInputElement.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebTextAreaElement.h"
 #include "third_party/WebKit/public/web/WebView.h"
+#include "ui/gfx/geometry/rect_f.h"
 
 using blink::WebElement;
 using blink::WebGestureEvent;
 using blink::WebInputElement;
 using blink::WebInputEvent;
 using blink::WebMouseEvent;
 using blink::WebNode;
 using blink::WebTextAreaElement;
 
 namespace {
@@ skipping 41 matching lines @@
 void PageClickTracker::OnDestruct() {
   // No-op. Don't delete |this|.
 }
 
 void PageClickTracker::DidHandleMouseEvent(const WebMouseEvent& event) {
   if (event.type != WebInputEvent::MouseDown ||
       event.button != WebMouseEvent::ButtonLeft) {
     return;
   }
 
-  PotentialActivationAt(event.x, event.y);
+  PotentialActivationAt(gfx::RectF(event.x, event.y, 1, 1));
 }
 
 void PageClickTracker::DidHandleGestureEvent(const WebGestureEvent& event) {
   if (event.type != WebGestureEvent::GestureTap)
     return;
 
-  PotentialActivationAt(event.x, event.y);
+  PotentialActivationAt(gfx::RectF(event.x - event.data.tap.width / 2.0,
+                                   event.y - event.data.tap.height / 2.0,
+                                   event.data.tap.width,
+                                   event.data.tap.height));
 }
 
 void PageClickTracker::FocusedNodeChanged(const WebNode& node) {
   was_focused_before_now_ = false;
 }
 
 void PageClickTracker::FocusChangeComplete() {

[Evan Stade, 2015/01/29 00:34:04]

also please change the name of this

[please use gerrit instead, 2015/01/29 01:47:04]

https://codereview.chromium.org/886663002/

   if (!clicked_node_.isNull()) {
     const WebInputElement input_element = GetTextWebInputElement(clicked_node_);
     if (!input_element.isNull()) {
       listener_->FormControlElementClicked(input_element,
                                            was_focused_before_now_);
     } else {
       const WebTextAreaElement textarea_element =
           GetWebTextAreaElement(clicked_node_);
       if (!textarea_element.isNull()) {
         listener_->FormControlElementClicked(textarea_element,
                                              was_focused_before_now_);
       }
     }
   }
 
   clicked_node_.reset();
   was_focused_before_now_ = true;
 }
 
-void PageClickTracker::PotentialActivationAt(int x, int y) {
+void PageClickTracker::PotentialActivationAt(const gfx::RectF& region) {
   WebElement focused_element = render_view()->GetFocusedElement();
   if (focused_element.isNull())
     return;
 
   if (!GetScaledBoundingBox(render_view()->GetWebView()->pageScaleFactor(),
-                            &focused_element).Contains(x, y)) {
+                            &focused_element).Intersects(region)) {
     return;
   }
 
   clicked_node_ = focused_element;
 }
 
 }  // namespace autofill