Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 883503002: Roll libvpx: cc9c0c:5da40c (Closed)

Created:
5 years, 11 months ago by Johann
Modified:
5 years, 11 months ago
Reviewers:
Tom Finegan, Yaowu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll libvpx: cc9c0c:5da40c Cherry-pick potential divide-by-zero fix https://codereview.chromium.org/877783004 This includes remnants of an attempt to turn on AVX2. That failed and the critical parts have been reverted. However, the attempt revealed some necessary changes which have been kept for the next attempt. These constitute a no-op for this particular roll. Enable AVX2: https://codereview.chromium.org/863143002 Fix GN build: https://codereview.chromium.org/865893004 https://codereview.chromium.org/817293008 https://codereview.chromium.org/866273003 Fix cpu detection: https://codereview.chromium.org/864393002 Disable AVX2: https://codereview.chromium.org/880513003 R=tomfinegan@chromium.org R=yaowu@chromium.org BUG=396572 Committed: https://crrev.com/09c4610490c2efb0e14a96a12250625bcca94dd6 Cr-Commit-Position: refs/heads/master@{#313182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Tom Finegan
lgtm
5 years, 11 months ago (2015-01-26 22:40:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883503002/1
5 years, 11 months ago (2015-01-26 23:00:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 00:53:03 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/09c4610490c2efb0e14a96a12250625bcca94dd6 Cr-Commit-Position: refs/heads/master@{#313182}
5 years, 11 months ago (2015-01-27 00:54:46 UTC) #5
yoichio
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/867883006/ by yoichio@chromium.org. ...
5 years, 11 months ago (2015-01-27 07:47:47 UTC) #6
Michael Achenbach
You can add the vista trybot on the next AVX2 change attempt. E.g. add when ...
5 years, 11 months ago (2015-01-27 11:48:28 UTC) #7
Johann
5 years, 11 months ago (2015-01-27 16:51:17 UTC) #8
Message was sent while issue was closed.
On 2015/01/27 11:48:28, Michael Achenbach wrote:
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_vista_rel_ng

Thanks. This is the information I was looking for last time.

Powered by Google App Engine
This is Rietveld 408576698