Issue 877783004: Cherry-pick potential divide-by-zero fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 877783004: Cherry-pick potential divide-by-zero fix (Closed)

Created:
5 years, 11 months ago by Johann

Modified:
5 years, 11 months ago

Reviewers:
Tom Finegan, Yaowu

CC:
wwcv, jzern, fgalligan1, Tom Finegan, Yaowu

Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Cherry-pick potential divide-by-zero fix Replace divide with look-up This commit replaces an integer divide with a table-lookup. It is to improve decoding speed, and at the same time, to reduce possible complications with a bug in AMD Family 12h processors: "665 Integer Divide Instruction May Cause Unpredictable Behavior" Change-Id: I678b707a538798a923850bac467e66e847e6def7 https://gerrit.chromium.org/gerrit/73570 R=tomfinegan@chromium.org R=yaowu@chromium.org BUG=396572 Committed: 5da40ca3395cd09443f3d4a3f8b86e495a6df364

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -76 lines)			Patch
M	source/libvpx/vp9/common/vp9_entropymode.c	View	3 chunks	+26 lines, -37 lines	0 comments	Download
M	source/libvpx/vp9/common/vp9_entropymv.c	View	3 chunks	+13 lines, -24 lines	0 comments	Download
M	source/libvpx/vp9/common/vp9_prob.h	View	2 chunks	+23 lines, -2 lines	0 comments	Download
M	source/libvpx/vp9/common/vp9_prob.c	View	1 chunk	+5 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johann

5 years, 11 months ago (2015-01-26 22:31:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5da40ca3395cd09443f3d4a3f8b86e495a6df364 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages