Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 865893004: Add avx2 sources to GN build file (Closed)

Created:
5 years, 11 months ago by Johann
Modified:
5 years, 11 months ago
Reviewers:
ckocagil, Tom Finegan
CC:
wwcv, jzern, fgalligan1
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add avx2 sources to GN build file TBR=tomfinegan@chromium.org Committed: 11ade561de716842ba299f11900490d293a44fcd

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M BUILD.gn View 2 chunks +15 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
Johann
Committed patchset #1 (id:1) manually as 11ade561de716842ba299f11900490d293a44fcd (presubmit successful).
5 years, 11 months ago (2015-01-22 17:04:36 UTC) #1
Johann
Cem, you touched some of the GN files here: https://codereview.chromium.org/603173004/ Specifically, you fixed some Windows ...
5 years, 11 months ago (2015-01-22 17:18:22 UTC) #3
Tom Finegan
On 2015/01/22 17:18:22, Johann wrote: > Cem, you touched some of the GN files here: ...
5 years, 11 months ago (2015-01-22 17:33:59 UTC) #4
ckocagil
5 years, 11 months ago (2015-01-22 18:25:14 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/865893004/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/865893004/diff/1/BUILD.gn#newcode135
BUILD.gn:135: cflags = [ "-mavx2" ]
This should be:

  if (is_win) {
    cflags = [ "/arch:AVX" ]
  } else {
    cflags = [ "-mavx2" ]
  }

Powered by Google App Engine
This is Rietveld 408576698