Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 880513003: Disable AVX2 (Closed)

Created:
5 years, 11 months ago by Johann
Modified:
5 years, 11 months ago
Reviewers:
Tom Finegan
CC:
wwcv, jzern, fgalligan1
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable AVX2 There remain some issue to be worked through wrt Win XP TBR=tomfinegan@chromium.org Committed: fcf367a08c3392876016e6e13e8bae7dedafe11b

Patch Set 1 #

Patch Set 2 : forgot to comment one more spot - not sure if GN allows empty rules and this is even necessary but … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -662 lines) Patch
M BUILD.gn View 1 2 chunks +17 lines, -16 lines 0 comments Download
M generate_gypi.sh View 5 chunks +7 lines, -2 lines 0 comments Download
M libvpx.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M libvpx_srcs.gni View 2 chunks +0 lines, -20 lines 0 comments Download
M libvpx_srcs_x86_64_intrinsics.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
M libvpx_srcs_x86_intrinsics.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
M source/config/linux/arm-neon-cpu-detect/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/arm-neon/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/arm/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/arm64/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/generic/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/ia32/vp9_rtcd.h View 35 chunks +0 lines, -60 lines 0 comments Download
M source/config/linux/ia32/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/ia32/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/ia32/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/mips64el/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/mipsel/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/x64/vp9_rtcd.h View 28 chunks +23 lines, -106 lines 0 comments Download
M source/config/linux/x64/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/x64/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/x64/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/mac/ia32/vp9_rtcd.h View 25 chunks +22 lines, -104 lines 0 comments Download
M source/config/mac/ia32/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/mac/ia32/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M source/config/mac/ia32/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/mac/x64/vp9_rtcd.h View 28 chunks +23 lines, -106 lines 0 comments Download
M source/config/mac/x64/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/mac/x64/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M source/config/mac/x64/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/nacl/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/win/ia32/vp9_rtcd.h View 35 chunks +0 lines, -60 lines 0 comments Download
M source/config/win/ia32/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/win/ia32/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M source/config/win/ia32/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M source/config/win/x64/vp9_rtcd.h View 28 chunks +23 lines, -106 lines 0 comments Download
M source/config/win/x64/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/win/x64/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M source/config/win/x64/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Johann
Diff back to cc9c0c5198e416173f480fb1f11e052f5c29a95b (previous successful row) shows differences in: BUILD.gn - new sections refernecing ...
5 years, 11 months ago (2015-01-26 19:16:09 UTC) #1
Johann
Committed patchset #2 (id:20001) manually as fcf367a08c3392876016e6e13e8bae7dedafe11b (presubmit successful).
5 years, 11 months ago (2015-01-26 19:16:23 UTC) #2
Tom Finegan
5 years, 11 months ago (2015-01-26 21:28:24 UTC) #3
Message was sent while issue was closed. 
On 2015/01/26 19:16:23, Johann wrote:
> Committed patchset #2 (id:20001) manually as
> fcf367a08c3392876016e6e13e8bae7dedafe11b (presubmit successful).

lgtm

Powered by Google App Engine
This is Rietveld 408576698