Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issue 883393005: Add IRT interface for PNaCl's sandboxed linker to use to talk to Chromium (Closed)

Created:
5 years, 10 months ago by Mark Seaborn
Modified:
5 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Add IRT interface for PNaCl's sandboxed linker to use to talk to Chromium This is a private IRT interface that PNaCl's sandboxed linker (Gold) will use for communicating with Chromium's renderer process. Initially, this is implemented using SRPC, using the same SRPC interface that Gold and Chromium currently use. This will allow direct use of SRPC to be removed from Gold. This IRT interface must be implemented in the NaCl repo currently because PNaCl's sel_universal-based testing uses this SRPC interface. Later, Chromium can be changed to provide its own implementation of this IRT interface, based on Chrome IPC. BUG=https://code.google.com/p/chromium/issues/detail?id=302078 TEST=tested with change to gold/nacl_file.cc (PNaCl linker) NOPRESUBMIT=true Committed: https://chromium.googlesource.com/native_client/src/native_client/+/6c1154966d275482620a31d6947e3e4863274b5d

Patch Set 1 #

Patch Set 2 : Fix Gyp #

Patch Set 3 : Comments #

Patch Set 4 : Add const #

Total comments: 2

Patch Set 5 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -1 line) Patch
M src/untrusted/irt/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/untrusted/irt/irt.gyp View 1 3 chunks +5 lines, -0 lines 0 comments Download
M src/untrusted/irt/irt_dev.h View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M src/untrusted/irt/irt_interfaces.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/untrusted/irt/irt_interfaces.c View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A src/untrusted/irt/irt_pnacl_translator.c View 1 2 3 4 1 chunk +57 lines, -0 lines 0 comments Download
M src/untrusted/irt/nacl.scons View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Mark Seaborn
Depends on a Chromium-side change: https://codereview.chromium.org/901053008/ Gold change: https://codereview.chromium.org/904583002/
5 years, 10 months ago (2015-02-05 18:15:36 UTC) #2
jvoung (off chromium)
LGTM https://codereview.chromium.org/883393005/diff/60001/src/untrusted/irt/irt_pnacl_translator.c File src/untrusted/irt/irt_pnacl_translator.c (right): https://codereview.chromium.org/883393005/diff/60001/src/untrusted/irt/irt_pnacl_translator.c#newcode30 src/untrusted/irt/irt_pnacl_translator.c:30: for (i = 0; i < obj_file_count; i++) ...
5 years, 10 months ago (2015-02-05 19:14:11 UTC) #3
Mark Seaborn
https://codereview.chromium.org/883393005/diff/60001/src/untrusted/irt/irt_pnacl_translator.c File src/untrusted/irt/irt_pnacl_translator.c (right): https://codereview.chromium.org/883393005/diff/60001/src/untrusted/irt/irt_pnacl_translator.c#newcode30 src/untrusted/irt/irt_pnacl_translator.c:30: for (i = 0; i < obj_file_count; i++) { ...
5 years, 10 months ago (2015-02-05 22:01:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883393005/80001
5 years, 10 months ago (2015-02-05 22:03:34 UTC) #7
commit-bot: I haz the power
Presubmit check for 883393005-80001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 10 months ago (2015-02-05 22:03:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/883393005/80001
5 years, 10 months ago (2015-02-05 22:45:44 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 23:14:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/native_client/src/native_client/+/6c1154966...

Powered by Google App Engine
This is Rietveld 408576698