Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 901053008: Revert of NaCl: Remove the IRT's Gyp dependency on libsrpc (Closed)

Created:
5 years, 10 months ago by Mark Seaborn
Modified:
5 years, 10 months ago
CC:
chromium-reviews, teravest
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of NaCl: Remove the IRT's Gyp dependency on libsrpc (patchset #1 id:1 of https://codereview.chromium.org/878623004/) Reason for revert: I was a bit too eager about removing the dependency on libsrpc. I'm preparing a NaCl change that will make the IRT depend on SRPC again (https://codereview.chromium.org/883393005/), as a step towards removing SRPC later. Unfortunately, untrusted.gypi doesn't support transitive library dependencies, so it's not enough just for the NaCl side to declare the dependency on libsrpc. Original issue's description: > NaCl: Remove the IRT's Gyp dependency on libsrpc > > Since I removed the IRT's calls to NaClSrpcModuleInit() and > NaClPluginLowLevelInitializationComplete(), the IRT no longer depends > on SRPC. > > BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 > TEST=build > > Committed: https://crrev.com/65a326a734d413e2124c6782b2e32a81ceca74c1 > Cr-Commit-Position: refs/heads/master@{#313664} BUG=302078 TEST=build Committed: https://crrev.com/959b409bb77024e26221aadad7bd8afc71cce6d3 Cr-Commit-Position: refs/heads/master@{#314874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ppapi/native_client/native_client.gyp View 6 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Mark Seaborn
Created Revert of NaCl: Remove the IRT's Gyp dependency on libsrpc
5 years, 10 months ago (2015-02-05 18:08:20 UTC) #1
Mark Seaborn
@teravest: Please ignore this for now. That dratted revert tool sent the e-mail too eagerly.
5 years, 10 months ago (2015-02-05 18:09:33 UTC) #2
Mark Seaborn
+jvoung for review.
5 years, 10 months ago (2015-02-05 18:20:57 UTC) #4
teravest
lgtm
5 years, 10 months ago (2015-02-05 18:23:49 UTC) #6
jvoung (off chromium)
lgtm
5 years, 10 months ago (2015-02-05 18:26:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/901053008/1
5 years, 10 months ago (2015-02-05 19:22:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 21:01:41 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 21:03:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/959b409bb77024e26221aadad7bd8afc71cce6d3
Cr-Commit-Position: refs/heads/master@{#314874}

Powered by Google App Engine
This is Rietveld 408576698