Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: src/untrusted/irt/irt_interfaces.c

Issue 883393005: Add IRT interface for PNaCl's sandboxed linker to use to talk to Chromium (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Cleanup Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/untrusted/irt/irt_interfaces.h ('k') | src/untrusted/irt/irt_pnacl_translator.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/untrusted/irt/irt_interfaces.c
diff --git a/src/untrusted/irt/irt_interfaces.c b/src/untrusted/irt/irt_interfaces.c
index bae8fd87aed94d731a9e0e064cea26616b99cf0d..44a22b6433aaa86da93151b35be29b655d703c78 100644
--- a/src/untrusted/irt/irt_interfaces.c
+++ b/src/untrusted/irt/irt_interfaces.c
@@ -124,6 +124,17 @@ static const struct nacl_irt_interface irt_interfaces[] = {
*/
{ NACL_IRT_CODE_DATA_ALLOC_v0_1, &nacl_irt_code_data_alloc,
sizeof(nacl_irt_code_data_alloc), non_pnacl_filter },
+ /*
+ * TODO(mseaborn): Ideally this interface should be hidden in processes
+ * that aren't PNaCl sandboxed translator processes. However, we haven't
+ * yet plumbed though a flag to indicate when a NaCl process is a PNaCl
+ * translator process. The risk of an app accidentally depending on the
+ * presence of this interface is much lower than for other non-stable IRT
+ * interfaces, because this interface is not useful to apps.
+ */
+ { NACL_IRT_PRIVATE_PNACL_TRANSLATOR_LINK_v0_1,
+ &nacl_irt_private_pnacl_translator_link,
+ sizeof(nacl_irt_private_pnacl_translator_link), NULL },
};
size_t nacl_irt_query_core(const char *interface_ident,
« no previous file with comments | « src/untrusted/irt/irt_interfaces.h ('k') | src/untrusted/irt/irt_pnacl_translator.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698