Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 881403003: Rename gdata_errorcode.h to drive_api_error_codes.h (Closed)

Created:
5 years, 10 months ago by satorux1
Modified:
5 years, 10 months ago
Reviewers:
kinuko, mtomasz, nhiroki, kinaba
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, zea+watch_chromium.org, tzik, tfarina, maxbogue+watch_chromium.org, nhiroki, pvalenzuela+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gdata_errorcode.h to drive_api_error_codes.h The term 'gdata' is no longer relevant, since we stiched from WAPI (GDATA based API) to Drive API. BUG=357038 TEST=everything builds as before Committed: https://crrev.com/1e04b42f4711bc16f194e3d45bde5b14d13afca8 Cr-Commit-Position: refs/heads/master@{#313676}

Patch Set 1 #

Patch Set 2 : fix typos in BUILD.gn #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+747 lines, -873 lines) Patch
M chrome/browser/apps/drive/drive_app_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/directory_loader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/directory_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/directory_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_errors.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_errors.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/move_operation.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/remove_operation.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/search_operation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/search_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/touch_operation.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/drive/file_task_executor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_task_executor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_task_executor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.h View 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 19 chunks +23 lines, -22 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler_unittest.cc View 44 chunks +54 lines, -45 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_revert_performer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_revert_performer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_revert_performer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/remove_performer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/remove_performer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/remove_performer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/drive/drive_api_service.cc View 4 chunks +7 lines, -7 lines 1 comment Download
M chrome/browser/drive/drive_api_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/drive_app_registry.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/drive/drive_app_registry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/drive/drive_app_registry_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/drive/drive_uploader.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/drive/drive_uploader.cc View 7 chunks +9 lines, -9 lines 1 comment Download
M chrome/browser/drive/drive_uploader_unittest.cc View 24 chunks +27 lines, -27 lines 1 comment Download
M chrome/browser/drive/fake_drive_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 26 chunks +29 lines, -29 lines 1 comment Download
M chrome/browser/drive/fake_drive_service_unittest.cc View 108 chunks +129 lines, -129 lines 1 comment Download
M chrome/browser/drive/test_util.cc View 1 chunk +3 lines, -3 lines 1 comment Download
M chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h View 1 chunk +17 lines, -17 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc View 19 chunks +43 lines, -43 lines 1 comment Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.cc View 4 chunks +4 lines, -4 lines 1 comment Download
M chrome/browser/sync_file_system/drive_backend/folder_creator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/folder_creator.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.h View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/uninstall_app_task.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/uninstall_app_task.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_test_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M google_apis/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/drive/auth_service.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/auth_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M google_apis/drive/auth_service_interface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/drive/base_requests.h View 18 chunks +23 lines, -23 lines 0 comments Download
M google_apis/drive/base_requests.cc View 19 chunks +23 lines, -23 lines 0 comments Download
M google_apis/drive/base_requests_server_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/drive/base_requests_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + google_apis/drive/drive_api_error_codes.h View 2 chunks +14 lines, -14 lines 0 comments Download
A + google_apis/drive/drive_api_error_codes.cc View 2 chunks +16 lines, -16 lines 0 comments Download
M google_apis/drive/drive_api_requests.h View 5 chunks +7 lines, -7 lines 0 comments Download
M google_apis/drive/drive_api_requests.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 31 chunks +31 lines, -31 lines 0 comments Download
M google_apis/drive/drive_common_callbacks.h View 1 chunk +5 lines, -5 lines 0 comments Download
D google_apis/drive/gdata_errorcode.h View 1 chunk +0 lines, -46 lines 0 comments Download
D google_apis/drive/gdata_errorcode.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M google_apis/drive/request_sender.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/drive/request_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/request_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/test_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/drive/test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/google_apis.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
satorux1
kinaba: drive stuff mtomasz: fsp stuff nhiroki: syncfs stuff
5 years, 10 months ago (2015-01-29 01:22:02 UTC) #2
kinaba
lgtm
5 years, 10 months ago (2015-01-29 01:50:52 UTC) #3
kinuko
syncfs stuff lgtm (on behalf of nhiroki)
5 years, 10 months ago (2015-01-29 06:07:27 UTC) #4
mtomasz
lgtm with nits https://codereview.chromium.org/881403003/diff/20001/chrome/browser/drive/drive_api_service.cc File chrome/browser/drive/drive_api_service.cc (right): https://codereview.chromium.org/881403003/diff/20001/chrome/browser/drive/drive_api_service.cc#newcode34 chrome/browser/drive/drive_api_service.cc:34: using google_apis::DRIVE_OTHER_ERROR; nit: Alpha order. https://codereview.chromium.org/881403003/diff/20001/chrome/browser/drive/drive_uploader.cc ...
5 years, 10 months ago (2015-01-29 06:18:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881403003/20001
5 years, 10 months ago (2015-01-29 06:22:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 07:51:35 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 07:53:43 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1e04b42f4711bc16f194e3d45bde5b14d13afca8
Cr-Commit-Position: refs/heads/master@{#313676}

Powered by Google App Engine
This is Rietveld 408576698