Issue 88063003: Switch CSSStyleDeclaration's property setter to new-style ExceptionState.

Issue 88063003: Switch CSSStyleDeclaration's property setter to new-style ExceptionState. (Closed)

Created:
7 years ago by Mike West

Modified:
7 years ago

Reviewers:
kenneth.r.christiansen

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, haraken, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Switch CSSStyleDeclaration's property setter to new-style ExceptionState. This passes the property name and object type into ExceptionState to avoid duplicating it at the point at which the exception is thrown. BUG=270033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162979

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	LayoutTests/fast/dom/computed-style-set-property-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/PropertySetCSSStyleDeclaration.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mike West

This depends on https://codereview.chromium.org/87963002/, so no trybots until that lands. Mind taking a look, Kenneth? ...

7 years ago (2013-11-26 12:20:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/88063003/1

7 years ago (2013-11-27 14:38:44 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=13921

7 years ago (2013-11-27 15:52:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/88063003/20001

7 years ago (2013-12-02 10:44:07 UTC) #5

Message was sent while issue was closed.

Change committed as 162979

Expand Messages | Collapse Messages