Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1616)

Side by Side Diff: Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 88063003: Switch CSSStyleDeclaration's property setter to new-style ExceptionState. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2007-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 } 222 }
223 223
224 void V8CSSStyleDeclaration::namedPropertySetterCustom(v8::Local<v8::String> name , v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<v8::Value>& info) 224 void V8CSSStyleDeclaration::namedPropertySetterCustom(v8::Local<v8::String> name , v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<v8::Value>& info)
225 { 225 {
226 CSSStyleDeclaration* imp = V8CSSStyleDeclaration::toNative(info.Holder()); 226 CSSStyleDeclaration* imp = V8CSSStyleDeclaration::toNative(info.Holder());
227 CSSPropertyInfo* propInfo = cssPropertyInfo(name); 227 CSSPropertyInfo* propInfo = cssPropertyInfo(name);
228 if (!propInfo) 228 if (!propInfo)
229 return; 229 return;
230 230
231 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>, proper tyValue, value); 231 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>, proper tyValue, value);
232 ExceptionState exceptionState(info.Holder(), info.GetIsolate()); 232 ExceptionState exceptionState(ExceptionState::SetterContext, getPropertyName (static_cast<CSSPropertyID>(propInfo->propID)), "CSSStyleDeclaration", info.Hold er(), info.GetIsolate());
233 imp->setPropertyInternal(static_cast<CSSPropertyID>(propInfo->propID), prope rtyValue, false, exceptionState); 233 imp->setPropertyInternal(static_cast<CSSPropertyID>(propInfo->propID), prope rtyValue, false, exceptionState);
234 234
235 if (exceptionState.throwIfNeeded()) 235 if (exceptionState.throwIfNeeded())
236 return; 236 return;
237 237
238 v8SetReturnValue(info, value); 238 v8SetReturnValue(info, value);
239 } 239 }
240 240
241 } // namespace WebCore 241 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/computed-style-set-property-expected.txt ('k') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698