Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp - Issue 88063003: Switch CSSStyleDeclaration's property setter to new-style ExceptionState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 88063003: Switch CSSStyleDeclaration's property setter to new-style ExceptionState. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/computed-style-set-property-expected.txt ('k') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

diff --git a/Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp b/Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

index 274b2a810117baef802acacdf74132f9294b11d6..43faed57a80a7005bf9211c98580d3ad807aa84e 100644

--- a/Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

+++ b/Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

@@ -229,7 +229,7 @@ void V8CSSStyleDeclaration::namedPropertySetterCustom(v8::Local<v8::String> name

return;

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>, propertyValue, value);

- ExceptionState exceptionState(info.Holder(), info.GetIsolate());

+ ExceptionState exceptionState(ExceptionState::SetterContext, getPropertyName(static_cast<CSSPropertyID>(propInfo->propID)), "CSSStyleDeclaration", info.Holder(), info.GetIsolate());

imp->setPropertyInternal(static_cast<CSSPropertyID>(propInfo->propID), propertyValue, false, exceptionState);

if (exceptionState.throwIfNeeded())

« no previous file with comments | « LayoutTests/fast/dom/computed-style-set-property-expected.txt ('k') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | no next file with comments »