Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(90)

Issue 8772033: Adds support for the GL_ANGLE_texture_usage and GL_EXT_texture_storage (Closed)

Created:
8 years, 11 months ago by Vangelis Kokkevis
Modified:
8 years, 10 months ago
CC:
chromium-reviews, jam, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Adds support for the GL_ANGLE_texture_usage and GL_EXT_texture_storage extensions to the command buffer and the WebGraphicsContext3D APIs. BUG=106142 TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113223

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 25

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+623 lines, -27 lines) Patch
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 5 chunks +28 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gl_mock.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 1 chunk +21 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 2 3 4 10 chunks +47 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 1 chunk +21 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 7 chunks +158 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 4 chunks +21 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 2 3 4 5 9 chunks +28 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 3 4 7 chunks +18 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 2 3 4 10 chunks +27 lines, -8 lines 0 comments Download
M third_party/khronos/GLES2/gl2ext.h View 1 4 chunks +45 lines, -0 lines 0 comments Download
M ui/gfx/gl/generate_bindings.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/gl/gl_interface.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Vangelis Kokkevis
Please review...
8 years, 11 months ago (2011-12-02 06:16:11 UTC) #1
vangelis
On 2011/12/02 06:16:11, Vangelis Kokkevis wrote: > Please review... Having trouble getting the TextureManagerTests to ...
8 years, 11 months ago (2011-12-02 08:27:42 UTC) #2
Vangelis Kokkevis
On 2011/12/02 08:27:42, vangelis wrote: > On 2011/12/02 06:16:11, Vangelis Kokkevis wrote: > > Please ...
8 years, 11 months ago (2011-12-02 17:30:25 UTC) #3
greggman
looks good. Just a few issues. Sorry this is so painful http://codereview.chromium.org/8772033/diff/3051/gpu/command_buffer/build_gles2_cmd_buffer.py File gpu/command_buffer/build_gles2_cmd_buffer.py (right): ...
8 years, 11 months ago (2011-12-02 18:33:24 UTC) #4
greggman
looks good. Just a few issues. Sorry this is so painful http://codereview.chromium.org/8772033/diff/3051/gpu/command_buffer/build_gles2_cmd_buffer.py File gpu/command_buffer/build_gles2_cmd_buffer.py (right): ...
8 years, 11 months ago (2011-12-02 18:33:24 UTC) #5
vangelis
Thanks for the review, Gregg. PTAL. http://codereview.chromium.org/8772033/diff/3051/gpu/command_buffer/build_gles2_cmd_buffer.py File gpu/command_buffer/build_gles2_cmd_buffer.py (right): http://codereview.chromium.org/8772033/diff/3051/gpu/command_buffer/build_gles2_cmd_buffer.py#newcode1058 gpu/command_buffer/build_gles2_cmd_buffer.py:1058: 'GL_RGBA8_OES', On 2011/12/02 ...
8 years, 11 months ago (2011-12-03 00:19:53 UTC) #6
greggman
lgtm http://codereview.chromium.org/8772033/diff/3051/gpu/command_buffer/build_gles2_cmd_buffer.py File gpu/command_buffer/build_gles2_cmd_buffer.py (right): http://codereview.chromium.org/8772033/diff/3051/gpu/command_buffer/build_gles2_cmd_buffer.py#newcode1058 gpu/command_buffer/build_gles2_cmd_buffer.py:1058: 'GL_RGBA8_OES', On 2011/12/03 00:19:53, vangelis wrote: > On ...
8 years, 11 months ago (2011-12-03 01:41:01 UTC) #7
vangelis
On 2011/12/03 01:41:01, greggman wrote: > lgtm > > http://codereview.chromium.org/8772033/diff/3051/gpu/command_buffer/build_gles2_cmd_buffer.py > File gpu/command_buffer/build_gles2_cmd_buffer.py (right): > ...
8 years, 10 months ago (2011-12-05 16:46:05 UTC) #8
Vangelis Kokkevis
Ken, Ben, can I have an OWNER's lgtm ?
8 years, 10 months ago (2011-12-05 17:26:26 UTC) #9
Ken Russell (switch to Gerrit)
8 years, 10 months ago (2011-12-05 19:52:28 UTC) #10
Sorry for the delay -- content/gpu/ and webkit/gpu/ LGTM.

Powered by Google App Engine
This is Rietveld 408576698