Extract buildAccessibilityTree() from the individual layout test.

Extract buildAccessibilityTree() from the individual layout test.

Extracted buildAccessibilityTree() from some of the individual layout tests and put it
into a helper file located at LayoutTests/resources/accessibility-helper.js

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189181

[k.czech, 2015-01-28 14:08:44]

k.czech@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[k.czech, 2015-01-28 15:13:16]

On 2015/01/28 14:08:45, k.czech wrote:

I'm wondering whether we should change buildAccessibilityTree to
dumpAccessibilityTree. buildAccessibilityTree just dumps the whole tree into the
output so the dump... would more descriptive. How do you think ?.

[dmazzoni, 2015-01-28 20:38:03]

lgtm

Thanks! I can see further cleanups but this is a great first step, it eliminates
a lot of duplicate code.

Just one thing I'd like you to fix in this change.

https://codereview.chromium.org/876003003/diff/20001/LayoutTests/accessibilit...
File LayoutTests/accessibility/first-letter-text-transform-causes-crash.html
(right):

https://codereview.chromium.org/876003003/diff/20001/LayoutTests/accessibilit...
LayoutTests/accessibility/first-letter-text-transform-causes-crash.html:26:
generateAccessibilityTree(accessibilityController.focusedElement);
I think this could call the full buildAccessibilityTree and it'd work fine.

The only reason this one was shorter is that it reproduced the crash without
dumping everything.

https://codereview.chromium.org/876003003/diff/20001/LayoutTests/resources/ac...
File LayoutTests/resources/accessibility-helper.js (right):

https://codereview.chromium.org/876003003/diff/20001/LayoutTests/resources/ac...
LayoutTests/resources/accessibility-helper.js:2: if (accessibilityObject.role ==
'AXRole: AXColumn' || accessibilityObject.role == 'AXRole:
AXTableHeaderContainer')
This should be a parameter rather than every test breaking on a column or table
header container. Maybe a parameter could be "rolesToIgnore" or something like
that.

[k.czech, 2015-01-29 00:09:25]

On 2015/01/28 20:38:03, dmazzoni wrote:
> lgtm
> 
> Thanks! I can see further cleanups but this is a great first step, it
eliminates
> a lot of duplicate code.
> 
> Just one thing I'd like you to fix in this change.
> 
>
https://codereview.chromium.org/876003003/diff/20001/LayoutTests/accessibilit...
> File LayoutTests/accessibility/first-letter-text-transform-causes-crash.html
> (right):
> 
>
https://codereview.chromium.org/876003003/diff/20001/LayoutTests/accessibilit...
> LayoutTests/accessibility/first-letter-text-transform-causes-crash.html:26:
> generateAccessibilityTree(accessibilityController.focusedElement);
> I think this could call the full buildAccessibilityTree and it'd work fine.
Yes, you are right.
> 
> The only reason this one was shorter is that it reproduced the crash without
> dumping everything.
> 
>
https://codereview.chromium.org/876003003/diff/20001/LayoutTests/resources/ac...
> File LayoutTests/resources/accessibility-helper.js (right):
> 
>
https://codereview.chromium.org/876003003/diff/20001/LayoutTests/resources/ac...
> LayoutTests/resources/accessibility-helper.js:2: if (accessibilityObject.role
==
> 'AXRole: AXColumn' || accessibilityObject.role == 'AXRole:
> AXTableHeaderContainer')
> This should be a parameter rather than every test breaking on a column or
table
> header container. Maybe a parameter could be "rolesToIgnore" or something like
> that.
Yes, you are right. Thanks.


Applied all suggestions.

[k.czech, 2015-01-29 10:36:05]

The CQ bit was checked by k.czech@samsung.com

[commit-bot: I haz the power, 2015-01-29 10:36:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/876003003/40001

[commit-bot: I haz the power, 2015-01-29 11:49:31]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189181