LayoutTests/accessibility/table-with-empty-thead-causes-crash.html - Issue 876003003: Extract buildAccessibilityTree() from the individual layout test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/accessibility/table-with-empty-thead-causes-crash.html

Issue 876003003: Extract buildAccessibilityTree() from the individual layout test. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated some tests and added rolesToIgnore param to helper function. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/accessibility/table-header-column-row.html ('k') | LayoutTests/accessibility/table-with-empty-thead-causes-crash-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/accessibility/table-with-empty-thead-causes-crash.html

diff --git a/LayoutTests/accessibility/table-with-empty-thead-causes-crash.html b/LayoutTests/accessibility/table-with-empty-thead-causes-crash.html

index 5fde24316734b8c06f1a6bd66e836dafd2dec242..23a83a09207fea5981b27f89174cf6c66295b2c6 100644

--- a/LayoutTests/accessibility/table-with-empty-thead-causes-crash.html

+++ b/LayoutTests/accessibility/table-with-empty-thead-causes-crash.html

@@ -1,17 +1,8 @@

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

<html>

<head>

-<script>

- function buildAccessibilityTree(accessibilityObject) {

- accessibilityObject.isEnabled

- var count = accessibilityObject.childrenCount;

- for (var i = 0; i < count; ++i)

- buildAccessibilityTree(accessibilityObject.childAtIndex(i));

- }

-</script>

+<script src="../resources/accessibility-helper.js"></script>

</head>

<body>

@@ -21,6 +12,7 @@

</table>

+<p>End of test</p>

@@ -29,7 +21,7 @@

if (window.accessibilityController) {

document.body.focus();

- buildAccessibilityTree(accessibilityController.focusedElement);

+ buildAccessibilityTree(accessibilityController.focusedElement, 0, 0, ['AXColumn', 'AXTableHeaderContainer']);

}

</script>