LayoutTests/accessibility/first-letter-text-transform-causes-crash.html - Issue 876003003: Extract buildAccessibilityTree() from the individual layout test.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/accessibility/first-letter-text-transform-causes-crash.html

Issue 876003003: Extract buildAccessibilityTree() from the individual layout test. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added another helper function. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/accessibility/div-within-anchors-causes-crash-expected.txt ('k') | LayoutTests/accessibility/legend.html » ('j') | LayoutTests/resources/accessibility-helper.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <style>	4 <style>

5 dt:first-letter{text-transform:uppercase;}	5 dt:first-letter{text-transform:uppercase;}

6 </style>	6 </style>

7 <script>

8

9 function buildAccessibilityTree(accessibilityObject) {

10 var count = accessibilityObject.childrenCount;

11 for (var i = 0; i < count; ++i)

12 buildAccessibilityTree(accessibilityObject.childAtIndex(i));

13 }

14 </script>

15 <script src="../resources/js-test.js"></script>	7 <script src="../resources/js-test.js"></script>

	8 <script src="../resources/accessibility-helper.js"></script>

16 </head>	9 </head>

17 <body>	10 <body>

18	11

19 <dt>dt</dt>	12 <dt>dt</dt>

20	13

21 <p id="description"></p>	14 <p id="description"></p>

22 <div id="console"></div>	15 <div id="console"></div>

23	16

24 <script>	17 <script>

25 description("First letter text transform causes assert and bad type cast. Th is can cause a crash.");	18 description("First letter text transform causes assert and bad type cast. Th is can cause a crash.");

26	19

27 // Trigger a layout operation to create the two RenderTextFragment instances .	20 // Trigger a layout operation to create the two RenderTextFragment instances .

28 document.body.children[0].offsetWidth;	21 document.body.children[0].offsetWidth;

29	22

30 if (window.accessibilityController) {	23 if (window.accessibilityController) {

31 // Build up full accessibility tree.	24 // Build up full accessibility tree.

32 document.body.focus();	25 document.body.focus();

33 buildAccessibilityTree(accessibilityController.focusedElement);	26 generateAccessibilityTree(accessibilityController.focusedElement);
	dmazzoni 2015/01/28 20:38:03 I think this could call the full buildAccessibilit I think this could call the full buildAccessibilityTree and it'd work fine. The only reason this one was shorter is that it reproduced the crash without dumping everything.
34 }	27 }

35	28

36 </script>	29 </script>

37	30

38 </body>	31 </body>

39 </html>	32 </html>

OLD	NEW