LayoutTests/accessibility/aria-tables.html - Issue 876003003: Extract buildAccessibilityTree() from the individual layout test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/accessibility/aria-tables.html

Issue 876003003: Extract buildAccessibilityTree() from the individual layout test. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated some tests and added rolesToIgnore param to helper function. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure.html ('k') | LayoutTests/accessibility/aria-tables-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/accessibility/aria-tables.html

diff --git a/LayoutTests/accessibility/aria-tables.html b/LayoutTests/accessibility/aria-tables.html

index 06029a1b197bd57590bfbf75547c26fb97375ab5..893934f0c831a0fd1e40fdedf8ee2dc6784aa5b7 100644

--- a/LayoutTests/accessibility/aria-tables.html

+++ b/LayoutTests/accessibility/aria-tables.html

@@ -1,4 +1,5 @@

+<script src="../resources/accessibility-helper.js"></script>

@@ -22,27 +23,8 @@

- function buildAccessibilityTree(accessibilityObject, i) {

- if(accessibilityObject.stringValue.indexOf('End of test') >= 0)

- return false;

- if (accessibilityObject.role == 'AXRole: AXColumn' || accessibilityObject.role == 'AXRole: AXTableHeaderContainer')

- return true;

- var indent = "";

- for (var k = 0; k < i; k++)

- indent += " ";

- debug(indent + accessibilityObject.role + " " + accessibilityObject.stringValue);

- var childrenCount = accessibilityObject.childrenCount;

- for (var j = 0; j < childrenCount; j++) {

- if (!buildAccessibilityTree(accessibilityObject.childAtIndex(j), i + 1))

- return false;

- }

- return true;

- }

if (window.accessibilityController) {

document.getElementById("body").focus();

- buildAccessibilityTree(accessibilityController.focusedElement, 0);

+ buildAccessibilityTree(accessibilityController.focusedElement, 0, 1, ['AXColumn', 'AXTableHeaderContainer']);

}

</script>