Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 875513005: [PATCH 10/11] ozone: evdev: Add a device factory proxy that forwards to device thread (Closed)

Created:
5 years, 11 months ago by spang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Add a device factory proxy that forwards to device thread This is part of a series moving IO on evdev devices to a fast thread, since UI thread is too slow for the cursor. Make a new class InputDeviceFactoryProxyEvdev that wraps InputDeviceFactoryEvdev and can be safely passed to another thread. When the other thread calls to manipulate devices, we'll post to InputDeviceFactoryEvdev on the device thread with the command. BUG=449710 TEST=boot link_freon & move mouse Committed: https://crrev.com/da763e4f5e87a1b4de0e158ef4c2246139f68fd6 Cr-Commit-Position: refs/heads/master@{#313938}

Patch Set 1 #

Patch Set 2 : updates for events_unittests #

Total comments: 2

Patch Set 3 : rebase & InputDeviceFactoryEvdevProxy #

Patch Set 4 : update comments #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -9 lines) Patch
M ui/events/ozone/BUILD.gn View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 3 4 3 chunks +7 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/input_controller_evdev.h View 1 2 3 4 3 chunks +4 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/input_controller_evdev.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/input_device_factory_evdev_proxy.h View 1 2 3 4 1 chunk +59 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/input_device_factory_evdev_proxy.cc View 1 2 3 4 1 chunk +126 lines, -0 lines 0 comments Download
M ui/events/ozone/events_ozone.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
spang
5 years, 11 months ago (2015-01-23 22:02:04 UTC) #2
spang
5 years, 11 months ago (2015-01-27 19:35:55 UTC) #3
alexst (slow to review)
lgtm https://codereview.chromium.org/875513005/diff/20001/ui/events/ozone/evdev/event_factory_evdev.h File ui/events/ozone/evdev/event_factory_evdev.h (right): https://codereview.chromium.org/875513005/diff/20001/ui/events/ozone/evdev/event_factory_evdev.h#newcode33 ui/events/ozone/evdev/event_factory_evdev.h:33: class InputDeviceFactoryProxyEvdev; InputDeviceFactoryEvdevProxy? I think it's weird to ...
5 years, 10 months ago (2015-01-28 19:52:58 UTC) #4
spang
https://codereview.chromium.org/875513005/diff/20001/ui/events/ozone/evdev/event_factory_evdev.h File ui/events/ozone/evdev/event_factory_evdev.h (right): https://codereview.chromium.org/875513005/diff/20001/ui/events/ozone/evdev/event_factory_evdev.h#newcode33 ui/events/ozone/evdev/event_factory_evdev.h:33: class InputDeviceFactoryProxyEvdev; On 2015/01/28 19:52:58, alexst wrote: > InputDeviceFactoryEvdevProxy? ...
5 years, 10 months ago (2015-01-28 21:10:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875513005/80001
5 years, 10 months ago (2015-01-30 17:15:11 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-01-30 17:49:57 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 17:51:08 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/da763e4f5e87a1b4de0e158ef4c2246139f68fd6
Cr-Commit-Position: refs/heads/master@{#313938}

Powered by Google App Engine
This is Rietveld 408576698