Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 87503004: Pass the Translate error type to the bubble (Closed)

Created:
7 years ago by hajimehoshi
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Pass the Translate error type to the bubble The error type will be used for UMA or the message on the bubble UI. BUG=318649 (UMA) TEST=gtest_filter=TranslateBubbleViewTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238344

Patch Set 1 : . #

Patch Set 2 : (rebasing) #

Total comments: 2

Patch Set 3 : sky's review #

Patch Set 4 : (rebasing) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -31 lines) Patch
M chrome/browser/translate/translate_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 2 3 7 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_ui_delegate.h View 1 2 4 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_ui_delegate.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_window.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/translate/translate_bubble_factory.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/translate/translate_bubble_factory.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/translate/translate_bubble_model.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/translate/translate_bubble_model_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/translate/translate_bubble_model_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hajimehoshi
Can you take a look? Thank you in advance.
7 years ago (2013-11-26 08:03:53 UTC) #1
sky
LGTM https://codereview.chromium.org/87503004/diff/50001/chrome/browser/translate/translate_ui_delegate.h File chrome/browser/translate/translate_ui_delegate.h (right): https://codereview.chromium.org/87503004/diff/50001/chrome/browser/translate/translate_ui_delegate.h#newcode55 chrome/browser/translate/translate_ui_delegate.h:55: TranslateErrors::Type error_type() { return error_type_; } Make method ...
7 years ago (2013-12-02 14:31:19 UTC) #2
hajimehoshi
Thank you! https://codereview.chromium.org/87503004/diff/50001/chrome/browser/translate/translate_ui_delegate.h File chrome/browser/translate/translate_ui_delegate.h (right): https://codereview.chromium.org/87503004/diff/50001/chrome/browser/translate/translate_ui_delegate.h#newcode55 chrome/browser/translate/translate_ui_delegate.h:55: TranslateErrors::Type error_type() { return error_type_; } On ...
7 years ago (2013-12-03 02:20:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/87503004/80001
7 years ago (2013-12-03 02:31:00 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195899
7 years ago (2013-12-03 05:29:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/87503004/80001
7 years ago (2013-12-03 05:30:35 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-03 11:18:33 UTC) #7
Message was sent while issue was closed. 
Change committed as 238344

Powered by Google App Engine
This is Rietveld 408576698