Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: chrome/browser/translate/translate_ui_delegate.cc

Issue 87503004: Pass the Translate error type to the bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (rebasing) Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/translate/translate_ui_delegate.h ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/translate_ui_delegate.h" 5 #include "chrome/browser/translate/translate_ui_delegate.h"
6 6
7 #include "base/i18n/string_compare.h" 7 #include "base/i18n/string_compare.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
11 #include "chrome/browser/translate/translate_browser_metrics.h" 11 #include "chrome/browser/translate/translate_browser_metrics.h"
12 #include "chrome/browser/translate/translate_manager.h" 12 #include "chrome/browser/translate/translate_manager.h"
13 #include "chrome/browser/translate/translate_prefs.h" 13 #include "chrome/browser/translate/translate_prefs.h"
14 #include "chrome/browser/translate/translate_tab_helper.h" 14 #include "chrome/browser/translate/translate_tab_helper.h"
15 #include "components/translate/common/translate_constants.h" 15 #include "components/translate/common/translate_constants.h"
16 #include "content/public/browser/browser_context.h" 16 #include "content/public/browser/browser_context.h"
17 #include "content/public/browser/navigation_entry.h" 17 #include "content/public/browser/navigation_entry.h"
18 #include "content/public/browser/web_contents.h" 18 #include "content/public/browser/web_contents.h"
19 #include "third_party/icu/source/i18n/unicode/coll.h" 19 #include "third_party/icu/source/i18n/unicode/coll.h"
20 #include "ui/base/l10n/l10n_util.h" 20 #include "ui/base/l10n/l10n_util.h"
21 21
22 TranslateUIDelegate::TranslateUIDelegate(content::WebContents* web_contents, 22 TranslateUIDelegate::TranslateUIDelegate(content::WebContents* web_contents,
23 const std::string& original_language, 23 const std::string& original_language,
24 const std::string& target_language) 24 const std::string& target_language,
25 TranslateErrors::Type error_type)
25 : web_contents_(web_contents), 26 : web_contents_(web_contents),
26 original_language_index_(NO_INDEX), 27 original_language_index_(NO_INDEX),
27 target_language_index_(NO_INDEX) { 28 target_language_index_(NO_INDEX),
29 error_type_(error_type) {
28 DCHECK(web_contents_); 30 DCHECK(web_contents_);
29 31
30 languages_ = 32 languages_ =
31 GetSortedLanguageNames(g_browser_process->GetApplicationLocale()); 33 GetSortedLanguageNames(g_browser_process->GetApplicationLocale());
32 34
33 for (std::vector<LanguageNamePair>::const_iterator iter = languages_.begin(); 35 for (std::vector<LanguageNamePair>::const_iterator iter = languages_.begin();
34 iter != languages_.end(); ++iter) { 36 iter != languages_.end(); ++iter) {
35 std::string language_code = iter->first; 37 std::string language_code = iter->first;
36 if (language_code == original_language) 38 if (language_code == original_language)
37 original_language_index_ = iter - languages_.begin(); 39 original_language_index_ = iter - languages_.begin();
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 const std::string& original_lang = GetOriginalLanguageCode(); 237 const std::string& original_lang = GetOriginalLanguageCode();
236 const std::string& target_lang = GetTargetLanguageCode(); 238 const std::string& target_lang = GetTargetLanguageCode();
237 if (value) 239 if (value)
238 prefs_->WhitelistLanguagePair(original_lang, target_lang); 240 prefs_->WhitelistLanguagePair(original_lang, target_lang);
239 else 241 else
240 prefs_->RemoveLanguagePairFromWhitelist(original_lang, target_lang); 242 prefs_->RemoveLanguagePairFromWhitelist(original_lang, target_lang);
241 243
242 UMA_HISTOGRAM_BOOLEAN(TranslateBrowserMetrics::GetMetricsName( 244 UMA_HISTOGRAM_BOOLEAN(TranslateBrowserMetrics::GetMetricsName(
243 TranslateBrowserMetrics::UMA_ALWAYS_TRANSLATE_LANG), true); 245 TranslateBrowserMetrics::UMA_ALWAYS_TRANSLATE_LANG), true);
244 } 246 }
OLDNEW
« no previous file with comments | « chrome/browser/translate/translate_ui_delegate.h ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698