Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3915)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 87503004: Pass the Translate error type to the bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (rebasing) Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/translate/translate_bubble_view.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index c0b4c52cde350609be1a01598421203618a3da87..347ca724447c880521f418b547e75368314023fc 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -141,6 +141,7 @@ TranslateBubbleView::~TranslateBubbleView() {
void TranslateBubbleView::ShowBubble(views::View* anchor_view,
content::WebContents* web_contents,
TranslateBubbleModel::ViewState type,
+ TranslateErrors::Type error_type,
Browser* browser) {
if (IsShowing()) {
// When the user reads the advanced setting panel, the bubble should not be
@@ -151,6 +152,7 @@ void TranslateBubbleView::ShowBubble(views::View* anchor_view,
return;
}
translate_bubble_view_->SwitchView(type);
+ translate_bubble_view_->model()->SetErrorType(error_type);
return;
}
@@ -159,7 +161,8 @@ void TranslateBubbleView::ShowBubble(views::View* anchor_view,
GetTranslateLanguages(web_contents, &source_language, &target_language);
scoped_ptr<TranslateUIDelegate> ui_delegate(
- new TranslateUIDelegate(web_contents, source_language, target_language));
+ new TranslateUIDelegate(web_contents, source_language, target_language,
+ error_type));
scoped_ptr<TranslateBubbleModel> model(
new TranslateBubbleModelImpl(type, ui_delegate.Pass()));
TranslateBubbleView* view = new TranslateBubbleView(anchor_view,

Powered by Google App Engine
This is Rietveld 408576698