Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: chrome/browser/ui/translate/translate_bubble_factory.cc

Issue 87503004: Pass the Translate error type to the bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (rebasing) Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/translate/translate_bubble_factory.cc
diff --git a/chrome/browser/ui/translate/translate_bubble_factory.cc b/chrome/browser/ui/translate/translate_bubble_factory.cc
index 8f0bd27c24534b79b55cfe7adf6c9d9181823bb0..95b9e9c640f989800f32b54e7e509f6c6dc9c7fb 100644
--- a/chrome/browser/ui/translate/translate_bubble_factory.cc
+++ b/chrome/browser/ui/translate/translate_bubble_factory.cc
@@ -11,11 +11,12 @@ namespace {
void ShowDefault(BrowserWindow* window,
content::WebContents* web_contents,
- TranslateBubbleModel::ViewState view_state) {
+ TranslateBubbleModel::ViewState view_state,
+ TranslateErrors::Type error_type) {
// |window| might be null when testing.
if (!window)
return;
- window->ShowTranslateBubble(web_contents, view_state);
+ window->ShowTranslateBubble(web_contents, view_state, error_type);
}
} // namespace
@@ -26,13 +27,15 @@ TranslateBubbleFactory::~TranslateBubbleFactory() {
// static
void TranslateBubbleFactory::Show(BrowserWindow* window,
content::WebContents* web_contents,
- TranslateBubbleModel::ViewState view_state) {
+ TranslateBubbleModel::ViewState view_state,
+ TranslateErrors::Type error_type) {
if (current_factory_) {
- current_factory_->ShowImplementation(window, web_contents, view_state);
+ current_factory_->ShowImplementation(window, web_contents, view_state,
+ error_type);
return;
}
- ShowDefault(window, web_contents, view_state);
+ ShowDefault(window, web_contents, view_state, error_type);
}
// static
« no previous file with comments | « chrome/browser/ui/translate/translate_bubble_factory.h ('k') | chrome/browser/ui/translate/translate_bubble_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698