Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 872113004: Modified OverviewMode's LabelButton bounds to cover the entire item. (Closed)

Created:
5 years, 10 months ago by Nina
Modified:
5 years, 9 months ago
Reviewers:
sadrul, sky, tdanderson, oshima, *flackr, msw
CC:
chromium-reviews, tdanderson+overview_chromium.org, kalyank, tfarina, bruthig
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modified OverviewMode's LabelButton bounds to cover the entire item. This way, we don't have to worry about custom targeting. A minor change had to be done to the LabelButton view code to avoid printing text on a view border. BUG=453441 Committed: https://crrev.com/8cdfe63203195b79686813d7cbd3029411ceba79 Cr-Commit-Position: refs/heads/master@{#315596}

Patch Set 1 #

Patch Set 2 : Removed wrong comment #

Patch Set 3 : Removed unnecessary changes from unittests #

Total comments: 8

Patch Set 4 : Changed how we modify label opacity to old, working way #

Patch Set 5 : Removed ignore_border_overlap from label_button as per msw suggestion. #

Total comments: 12

Patch Set 6 : Reworked LabelButton changes. #

Total comments: 4

Patch Set 7 : Fixed nits #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -340 lines) Patch
M ash/ash.gyp View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
D ash/wm/overview/overview_window_button.h View 1 chunk +0 lines, -71 lines 0 comments Download
D ash/wm/overview/overview_window_button.cc View 1 chunk +0 lines, -155 lines 0 comments Download
D ash/wm/overview/overview_window_targeter.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ash/wm/overview/overview_window_targeter.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M ash/wm/overview/window_selector_item.h View 1 2 3 4 5 6 5 chunks +34 lines, -5 lines 0 comments Download
M ash/wm/overview/window_selector_item.cc View 1 2 3 4 5 6 11 chunks +101 lines, -11 lines 1 comment Download
M ash/wm/overview/window_selector_unittest.cc View 1 2 4 chunks +5 lines, -12 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 1 2 3 4 5 4 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 32 (10 generated)
Nina
Hi Rob, Can you give this patch a first look? Thanks!
5 years, 10 months ago (2015-01-29 20:48:36 UTC) #3
flackr
ash/wm lgtm, I'm curious about why we need to ignore the vertical border by default ...
5 years, 10 months ago (2015-01-30 15:34:05 UTC) #4
Nina
Hi Sadrul, Can you please give /ui/* a look on this patch? Rob, please see ...
5 years, 10 months ago (2015-01-30 15:44:32 UTC) #7
tdanderson
Hi Scott, would you mind taking a look at the changes in ui/views?
5 years, 10 months ago (2015-02-03 19:01:28 UTC) #10
sky
+msw https://codereview.chromium.org/872113004/diff/40001/ui/views/controls/button/label_button.cc File ui/views/controls/button/label_button.cc (right): https://codereview.chromium.org/872113004/diff/40001/ui/views/controls/button/label_button.cc#newcode327 ui/views/controls/button/label_button.cc:327: ignore_vertical_overlap_ ? 0 : child_area.y()); On 2015/01/30 15:44:32, ...
5 years, 10 months ago (2015-02-03 21:40:02 UTC) #12
Nina
We can always make |ignore_vertical_overlap_| default to false and only set in to true for ...
5 years, 10 months ago (2015-02-03 22:11:59 UTC) #13
sadrul
On 2015/02/03 22:11:59, Nicolás wrote: > We can always make |ignore_vertical_overlap_| default to false and ...
5 years, 10 months ago (2015-02-03 23:48:11 UTC) #14
msw
https://codereview.chromium.org/872113004/diff/40001/ash/wm/overview/window_selector_item.cc File ash/wm/overview/window_selector_item.cc (right): https://codereview.chromium.org/872113004/diff/40001/ash/wm/overview/window_selector_item.cc#newcode288 ash/wm/overview/window_selector_item.cc:288: window_label_button_view_->set_ignore_vertical_overlap(false); Would you mind posting a screenshot of what ...
5 years, 10 months ago (2015-02-03 23:50:20 UTC) #15
Nina
Please see my comments below, thanks. https://codereview.chromium.org/872113004/diff/40001/ash/wm/overview/window_selector_item.cc File ash/wm/overview/window_selector_item.cc (right): https://codereview.chromium.org/872113004/diff/40001/ash/wm/overview/window_selector_item.cc#newcode288 ash/wm/overview/window_selector_item.cc:288: window_label_button_view_->set_ignore_vertical_overlap(false); On 2015/02/03 ...
5 years, 10 months ago (2015-02-04 16:20:11 UTC) #16
flackr
https://codereview.chromium.org/872113004/diff/40001/ui/views/controls/button/label_button.cc File ui/views/controls/button/label_button.cc (right): https://codereview.chromium.org/872113004/diff/40001/ui/views/controls/button/label_button.cc#newcode327 ui/views/controls/button/label_button.cc:327: ignore_vertical_overlap_ ? 0 : child_area.y()); On 2015/02/04 16:20:11, Nicolás ...
5 years, 10 months ago (2015-02-04 16:39:08 UTC) #17
bruthig
I pulled your CL and was overlaying the swipe-to-close feature work and I noticed that ...
5 years, 10 months ago (2015-02-04 16:56:43 UTC) #18
msw
You might be able to solve this by having the Label bounds respect GetChildAreaBounds, but ...
5 years, 10 months ago (2015-02-04 18:12:32 UTC) #19
Nina
On 2015/02/04 16:56:43, bruthig wrote: > I pulled your CL and was overlaying the swipe-to-close ...
5 years, 10 months ago (2015-02-04 19:06:32 UTC) #20
Nina
msw@, please review label_button.[h|cc]. I modified the Layout code to use GetChildItemBounds(). flackr@, can you ...
5 years, 10 months ago (2015-02-06 16:06:13 UTC) #21
msw
I *really* recommend just using two buttons (one for the image at the top, and ...
5 years, 10 months ago (2015-02-06 21:24:26 UTC) #22
Nina
msw@, please see my attached comments and changes. I decided to refactor the code following ...
5 years, 10 months ago (2015-02-09 16:35:10 UTC) #23
msw
lgtm with nits, sorry for the runaround here... Feel free to add proper vertical layout ...
5 years, 10 months ago (2015-02-09 23:45:27 UTC) #24
sky
LGTM
5 years, 10 months ago (2015-02-10 18:28:10 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872113004/120001
5 years, 10 months ago (2015-02-10 18:31:25 UTC) #28
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 10 months ago (2015-02-10 18:36:04 UTC) #29
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/8cdfe63203195b79686813d7cbd3029411ceba79 Cr-Commit-Position: refs/heads/master@{#315596}
5 years, 10 months ago (2015-02-10 18:37:01 UTC) #30
oshima
5 years, 10 months ago (2015-02-10 21:43:16 UTC) #32
Message was sent while issue was closed.
https://codereview.chromium.org/872113004/diff/120001/ash/wm/overview/window_...
File ash/wm/overview/window_selector_item.cc (right):

https://codereview.chromium.org/872113004/diff/120001/ash/wm/overview/window_...
ash/wm/overview/window_selector_item.cc:104: : LabelButton(listener, text) {
you need to initialize top_padding_ here.

Powered by Google App Engine
This is Rietveld 408576698