Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 424663008: Use the full LabelButton height for text layout. (Closed)

Created:
6 years, 4 months ago by msw
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Use the full LabelButton height for text layout. This allows tall text to paint over LabelButton borders. (horizontal insets are still respected as they were before) This more closely matches the old TextButton behavior. See 397995_hi[_after].png at http://crbug.com/397995#c3 BUG=397995 TEST=Hindi bookmark buttons layout text better. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/views/controls/button/label_button.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
msw
Hey Scott, please take a look; thanks!
6 years, 4 months ago (2014-07-28 19:57:11 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-07-28 20:16:44 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 4 months ago (2014-07-28 20:16:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/424663008/1
6 years, 4 months ago (2014-07-28 20:35:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-28 22:33:07 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 23:42:27 UTC) #6
Message was sent while issue was closed.
Change committed as 286027

Powered by Google App Engine
This is Rietveld 408576698