Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 872073003: check-webkit-style: Angle Bracket Parsing in Templates (Closed)

Created:
5 years, 10 months ago by rwlbuis
Modified:
5 years, 10 months ago
Reviewers:
adamk
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

check-webkit-style: Angle Bracket Parsing in Templates Add checks for both items listed under "Angle Bracket Parsing in Templates" in: http://chromium-cpp.appspot.com/ BUG=449681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M Tools/Scripts/webkitpy/style/checkers/cpp.py View 2 chunks +9 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
rwlbuis
PTAL. This has already helped me with the current inspector fix patch: https://codereview.chromium.org/884753003/
5 years, 10 months ago (2015-01-28 20:56:26 UTC) #2
adamk
lgtm
5 years, 10 months ago (2015-01-28 21:04:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872073003/1
5 years, 10 months ago (2015-01-28 21:15:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/48187)
5 years, 10 months ago (2015-01-28 23:28:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872073003/1
5 years, 10 months ago (2015-01-29 00:08:53 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 00:51:56 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189149

Powered by Google App Engine
This is Rietveld 408576698