Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 884753003: Fix template angle bracket syntax in inspector (Closed)

Created:
5 years, 10 months ago by rwlbuis
Modified:
5 years, 10 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, shans, apavlov+blink_chromium.org, rjwright, Steve Block, caseq+blink_chromium.org, aandrey+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, blink-reviews-animation_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix template angle bracket syntax in inspector In C++11 the parser is able to parse >> as the end of the template argument list. BUG=449681

Patch Set 1 #

Patch Set 2 : Some more fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -280 lines) Patch
M Source/core/inspector/AsyncCallTracker.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/CodeGeneratorInspector.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/CodeGeneratorInspectorStrings.py View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/ConsoleMessageStorage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ContentSearchUtils.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ContentSearchUtils.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/DOMPatchSupport.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/inspector/InjectedScript.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InjectedScript.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InjectedScriptBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptHost.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorBaseAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 7 chunks +16 lines, -16 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 18 chunks +29 lines, -29 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 1 5 chunks +16 lines, -16 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 25 chunks +34 lines, -34 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 4 chunks +11 lines, -11 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorHistory.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 10 chunks +14 lines, -14 lines 0 comments Download
M Source/core/inspector/InspectorNodeIds.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorResourceContentLoader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorResourceContentLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorRuntimeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorRuntimeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/PageRuntimeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/PromiseTracker.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/PromiseTracker.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/ScriptArguments.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ScriptCallStack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ScriptCallStack.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/ScriptProfile.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/ScriptProfile.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/inspector/TraceEventDispatcher.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/TraceEventDispatcher.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/V8AsyncCallTracker.h View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/cpp.py View 1 2 chunks +9 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
rwlbuis
PTAL
5 years, 10 months ago (2015-01-28 20:54:00 UTC) #2
pfeldman
What does it improve? I can clearly see how it makes my git blame one ...
5 years, 10 months ago (2015-01-28 21:04:50 UTC) #3
rwlbuis
On 2015/01/28 21:04:50, pfeldman wrote: > What does it improve? I can clearly see how ...
5 years, 10 months ago (2015-01-28 21:18:46 UTC) #4
dgozman
On 2015/01/28 21:18:46, rwlbuis wrote: > On 2015/01/28 21:04:50, pfeldman wrote: > > What does ...
5 years, 10 months ago (2015-01-29 06:14:40 UTC) #5
pfeldman
lets mark it officially as not lgtm
5 years, 10 months ago (2015-01-29 09:55:20 UTC) #6
rwlbuis
5 years, 10 months ago (2015-01-29 13:13:07 UTC) #7
On 2015/01/29 09:55:20, pfeldman wrote:
> lets mark it officially as not lgtm

Ok. Converting on the go could take a long time though. At least there is now a
style checker rule:

https://codereview.chromium.org/872073003/

Powered by Google App Engine
This is Rietveld 408576698