check-webkit-style: Angle Bracket Parsing in Templates

Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

 # -*- coding: utf-8; -*-
 #
 # Copyright (C) 2011 Google Inc. All rights reserved.
 # Copyright (C) 2009 Torch Mobile Inc.
 # Copyright (C) 2009 Apple Inc. All rights reserved.
 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org)
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
@@ skipping 1767 matching lines @@
         self.assert_lint('a<Foo*> t <<= &b & &c; // Test', '')
         self.assert_lint('a<Foo*> t <<= *b / &c; // Test', '')
         self.assert_lint('if (a=b == 1)', 'Missing spaces around =  [whitespace/operators] [4]')
         self.assert_lint('a = 1<<20', 'Missing spaces around <<  [whitespace/operators] [3]')
         self.assert_lint('a = 1>> 20', 'Missing spaces around >>  [whitespace/operators] [3]')
         self.assert_lint('a = 1 >>20', 'Missing spaces around >>  [whitespace/operators] [3]')
         self.assert_lint('a = 1>>20', 'Missing spaces around >>  [whitespace/operators] [3]')
         self.assert_lint('func(OwnPtr<Vector<Foo>>)', '')
         self.assert_lint('func(OwnPtr<Vector<Foo>> foo)', '')
         self.assert_lint('func(OwnPtr<HashMap<Foo, Member<Bar>>>)', '')
+        self.assert_lint('func(OwnPtr<Vector<Foo> >)', 'Use >> for ending template instead of > >.  [readability/templatebrackets] [3]')
+        self.assert_lint('func(OwnPtr<HashMap<Foo, Member<Bar>> >)', 'Use >> for ending template instead of > >.  [readability/templatebrackets] [3]')
+        self.assert_lint('func(OwnPtr<HashMap<Foo, Member<Bar> >>)', 'Use >> for ending template instead of > >.  [readability/templatebrackets] [3]')
+        self.assert_lint('func(OwnPtr<HashMap<Foo, Member<Bar> > >)', 'Use >> for ending template instead of > >.  [readability/templatebrackets] [3]')
+        self.assert_lint('Vector< ::Foo>)', 'Use <:: for template start instead of < ::.  [readability/templatebrackets] [3]')
+        self.assert_lint('Vector<Vector< ::Foo>>)', 'Use <:: for template start instead of < ::.  [readability/templatebrackets] [3]')
         # FIXME: The following test should not show any error.
         self.assert_lint('func(OwnPtr<HashMap<Foo, Member<Bar\n    >>>)',
                          'Missing spaces around <  [whitespace/operators] [3]')
         self.assert_lint('if (a = b == 1)', '')
         self.assert_lint('a = 1 << 20', '')
         self.assert_multi_line_lint('#include <sys/io.h>\n', '')
         self.assert_multi_line_lint('#import <foo/bar.h>\n', '')
 
     def test_operator_methods(self):
         self.assert_lint('String operator+(const String&, const String&);', '')
@@ skipping 3116 matching lines @@
         self.assert_lint('const int UNDER_SCORE;',
                          'UNDER_SCORE' + name_underscore_error_message)
         self.assert_lint('static inline const char const& const under_score;',
                          'under_score' + name_underscore_error_message)
         self.assert_lint('WebCore::RenderObject* under_score;',
                          'under_score' + name_underscore_error_message)
         self.assert_lint('int func_name();',
                          'func_name' + name_underscore_error_message)
         self.assert_lint('RefPtr<RenderObject*> under_score;',
                          'under_score' + name_underscore_error_message)
-        self.assert_lint('WTF::Vector<WTF::RefPtr<const RenderObject* const> > under_score;',
+        self.assert_lint('WTF::Vector<WTF::RefPtr<const RenderObject* const>> under_score;',
                          'under_score' + name_underscore_error_message)
         self.assert_lint('int under_score[];',
                          'under_score' + name_underscore_error_message)
         self.assert_lint('struct dirent* under_score;',
                          'under_score' + name_underscore_error_message)
         self.assert_lint('long under_score;',
                          'under_score' + name_underscore_error_message)
         self.assert_lint('long long under_score;',
                          'under_score' + name_underscore_error_message)
         self.assert_lint('long double under_score;',
@@ skipping 266 matching lines @@
     def test_ne(self):
         """Test __ne__ inequality function."""
         checker1 = self._checker()
         checker2 = self._checker()
 
         # != calls __ne__.
         # By default, __ne__ always returns true on different objects.
         # Thus, just check the distinguishing case to verify that the
         # code defines __ne__.
         self.assertFalse(checker1 != checker2)