Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1966)

Unified Diff: Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

Issue 872073003: check-webkit-style: Angle Bracket Parsing in Templates (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/Scripts/webkitpy/style/checkers/cpp.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
diff --git a/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py b/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
index 42ffe18747624d20b1b70174cf1e3432a9e2c209..70ac696e9ff981f98e9b3d5f24d87855cb466f75 100644
--- a/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
+++ b/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
@@ -1785,6 +1785,12 @@ class CppStyleTest(CppStyleTestBase):
self.assert_lint('func(OwnPtr<Vector<Foo>>)', '')
self.assert_lint('func(OwnPtr<Vector<Foo>> foo)', '')
self.assert_lint('func(OwnPtr<HashMap<Foo, Member<Bar>>>)', '')
+ self.assert_lint('func(OwnPtr<Vector<Foo> >)', 'Use >> for ending template instead of > >. [readability/templatebrackets] [3]')
+ self.assert_lint('func(OwnPtr<HashMap<Foo, Member<Bar>> >)', 'Use >> for ending template instead of > >. [readability/templatebrackets] [3]')
+ self.assert_lint('func(OwnPtr<HashMap<Foo, Member<Bar> >>)', 'Use >> for ending template instead of > >. [readability/templatebrackets] [3]')
+ self.assert_lint('func(OwnPtr<HashMap<Foo, Member<Bar> > >)', 'Use >> for ending template instead of > >. [readability/templatebrackets] [3]')
+ self.assert_lint('Vector< ::Foo>)', 'Use <:: for template start instead of < ::. [readability/templatebrackets] [3]')
+ self.assert_lint('Vector<Vector< ::Foo>>)', 'Use <:: for template start instead of < ::. [readability/templatebrackets] [3]')
# FIXME: The following test should not show any error.
self.assert_lint('func(OwnPtr<HashMap<Foo, Member<Bar\n >>>)',
'Missing spaces around < [whitespace/operators] [3]')
@@ -4921,7 +4927,7 @@ class WebKitStyleTest(CppStyleTestBase):
'func_name' + name_underscore_error_message)
self.assert_lint('RefPtr<RenderObject*> under_score;',
'under_score' + name_underscore_error_message)
- self.assert_lint('WTF::Vector<WTF::RefPtr<const RenderObject* const> > under_score;',
+ self.assert_lint('WTF::Vector<WTF::RefPtr<const RenderObject* const>> under_score;',
'under_score' + name_underscore_error_message)
self.assert_lint('int under_score[];',
'under_score' + name_underscore_error_message)
« no previous file with comments | « Tools/Scripts/webkitpy/style/checkers/cpp.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698