Define class names for views class in c/b/ui/views

Define class names for views class in c/b/ui/views so that they show up on chrome://tracing

We're working on UI junk elimination and this is to help identify the class/methods that spend too long on UI thread.

BUG=450703
Committed: https://crrev.com/e7953145b624ee7426f1f62d35253486939dcce6
Cr-Commit-Position: refs/heads/master@{#313131}

[oshima, 2015-01-22 10:38:41]

Patchset #2 (id:20001) has been deleted

[oshima, 2015-01-22 10:38:45]

Patchset #1 (id:1) has been deleted

[oshima, 2015-01-22 10:46:58]

Patchset #1 (id:40001) has been deleted

[oshima, 2015-01-22 10:47:19]

Patchset #1 (id:60001) has been deleted

[oshima, 2015-01-22 10:52:05]

oshima@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-01-22 17:56:17]

https://codereview.chromium.org/869453002/diff/80001/chrome/browser/ui/views/...
File chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h (right):

https://codereview.chromium.org/869453002/diff/80001/chrome/browser/ui/views/...
chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h:31: static
const char kViewClassName[];
Why does this need to be a public static member?  Why can't we just implement
GetClassName as:

  return "Foo";

?  Even if that's not possible, couldn't this be a static local to that
function, or a file-scoped constant at the minimum?

Same comment applies to all other files in this CL.

[oshima, 2015-01-22 20:39:25]

On 2015/01/22 17:56:17, Peter Kasting wrote:
>
https://codereview.chromium.org/869453002/diff/80001/chrome/browser/ui/views/...
> File chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h
(right):
> 
>
https://codereview.chromium.org/869453002/diff/80001/chrome/browser/ui/views/...
> chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h:31: static
> const char kViewClassName[];
> Why does this need to be a public static member?  Why can't we just implement
> GetClassName as:
> 
>   return "Foo";
> 
> ?  Even if that's not possible, couldn't this be a static local to that
> function, or a file-scoped constant at the minimum?
> 
> Same comment applies to all other files in this CL.

I'm following the pattern in other view sub classes (see classes in ui/views or
omnibox_view_views.h)

I believe this is to allow you to check view's class name w/o RTTI

ex:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

although, this isn't really important in my context.

I don't have much opinion and am happy to change the way you want (return
"Foo"). Please let me know.

[Peter Kasting, 2015-01-22 21:48:47]

On 2015/01/22 20:39:25, oshima wrote:
> On 2015/01/22 17:56:17, Peter Kasting wrote:
> >
>
https://codereview.chromium.org/869453002/diff/80001/chrome/browser/ui/views/...
> > File chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h
> (right):
> > 
> >
>
https://codereview.chromium.org/869453002/diff/80001/chrome/browser/ui/views/...
> > chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h:31:
static
> > const char kViewClassName[];
> > Why does this need to be a public static member?  Why can't we just
implement
> > GetClassName as:
> > 
> >   return "Foo";
> > 
> > ?  Even if that's not possible, couldn't this be a static local to that
> > function, or a file-scoped constant at the minimum?
> > 
> > Same comment applies to all other files in this CL.
> 
> I'm following the pattern in other view sub classes (see classes in ui/views
or
> omnibox_view_views.h)
> 
> I believe this is to allow you to check view's class name w/o RTTI
> 
> ex:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
> 
> although, this isn't really important in my context.
> 
> I don't have much opinion and am happy to change the way you want (return
> "Foo"). Please let me know.

As you note, the places in the code above actually need to refer to the
classname elsewhere.  In that case, defining as a public static makes sense, as
the alternative would be to hardcode the class name string in the caller, which
would be fragile.

I would avoid this, and just put the string in the function directly, in any
case where you don't need such functionality, especially if you intend to remove
these names again someday.  We can always make something a public static as
needed if code elsewhere wants to start referring to the name of a particular
class.

[oshima, 2015-01-23 06:35:33]

Patchset #2 (id:100001) has been deleted

[oshima, 2015-01-23 06:36:15]

On 2015/01/22 21:48:47, Peter Kasting wrote:
> On 2015/01/22 20:39:25, oshima wrote:
> > On 2015/01/22 17:56:17, Peter Kasting wrote:
> > >
> >
>
https://codereview.chromium.org/869453002/diff/80001/chrome/browser/ui/views/...
> > > File chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h
> > (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/869453002/diff/80001/chrome/browser/ui/views/...
> > > chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h:31:
> static
> > > const char kViewClassName[];
> > > Why does this need to be a public static member?  Why can't we just
> implement
> > > GetClassName as:
> > > 
> > >   return "Foo";
> > > 
> > > ?  Even if that's not possible, couldn't this be a static local to that
> > > function, or a file-scoped constant at the minimum?
> > > 
> > > Same comment applies to all other files in this CL.
> > 
> > I'm following the pattern in other view sub classes (see classes in ui/views
> or
> > omnibox_view_views.h)
> > 
> > I believe this is to allow you to check view's class name w/o RTTI
> > 
> > ex:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
> > 
> > although, this isn't really important in my context.
> > 
> > I don't have much opinion and am happy to change the way you want (return
> > "Foo"). Please let me know.
> 
> As you note, the places in the code above actually need to refer to the
> classname elsewhere.  In that case, defining as a public static makes sense,
as
> the alternative would be to hardcode the class name string in the caller,
which
> would be fragile.
> 
> I would avoid this, and just put the string in the function directly, in any
> case where you don't need such functionality, especially if you intend to
remove
> these names again someday.  We can always make something a public static as
> needed if code elsewhere wants to start referring to the name of a particular
> class.
Done. PTAL

[Peter Kasting, 2015-01-23 07:28:11]

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h:34: const
char* GetClassName() const override;
In theory, these are listed in the same order that they're listed in the base
class declaration.

In practice we probably already don't get this right in a lot of places, but it
would be nice not to introduce new instances thereof.

Also (and this will probably make your life easier in this regard), all the
GetClassName() overrides you're adding should be private, since no one needs to
call them via a derived class pointer.  Again, we should have been doing this
for all such overrides, but we're already sloppy about it and you don't need to
fix existing cases.

(These comments apply throughout the CL)

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc:60: gi
This typo will break the compile.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_sync_promo_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_sync_promo_view.h:24: const char*
GetClassName() const override;
Nit: This should go after the StyledLabelListener override, to match the order
of the parent class declarations above.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/keyword_hint_view.cc (left):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/keyword_hint_view.cc:24: 
Nit: Don't remove this (I generally try to separate sections of the .cc files I
own with double blank lines)

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/keyword_hint_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/keyword_hint_view.h:44: // Views:
Nit: views::View:

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/selected_keyword_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/selected_keyword_view.h:29: // views::View:
This class inherits from IconLabelBubbleView, not views::View.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/login_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/login_view.h:28: // View:
Nit: views::View:

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc:24: namespace {
Nit: Blank line below this

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h:54: // Overridden
from views::View:
Nit: You're welcome, but not obligated, to remove the "Overridden from"s in this
file similarly to what you did in bookmark_bubble_view.h.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/tab_icon_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/tab_icon_view.h:36: // views::View:
Nit: This should refer to view::MenuButton instead.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/back_button.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/back_button.h:33: // NativeThemeDelegate:
This class doesn't inherit directly from NativeThemeDelegate, View, or
LabelButton, so these should all be in a single "ToolbarButton:" section,
ordered in the order in which ToolbarButton inherits from them.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/home_button.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/home_button.h:28: // views::View:
Nit: Again, this should be "ToolbarButton:".

[oshima, 2015-01-24 01:12:18]

Patchset #3 (id:140001) has been deleted

[oshima, 2015-01-24 01:12:26]

Patchset #3 (id:160001) has been deleted

[oshima, 2015-01-24 01:23:07]

Uploaded new patch. PTAL.

* moved GetClassName() to private
* made other methods private when they're not accesed via a derived class
pointer when possible, or change is small.
* reordered methods to match the super class when the change is small.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h:34: const
char* GetClassName() const override;
On 2015/01/23 07:28:10, Peter Kasting wrote:
> In theory, these are listed in the same order that they're listed in the base
> class declaration.
> 
> In practice we probably already don't get this right in a lot of places, but
it
> would be nice not to introduce new instances thereof.
> 
> Also (and this will probably make your life easier in this regard), all the
> GetClassName() overrides you're adding should be private, since no one needs
to
> call them via a derived class pointer.  Again, we should have been doing this
> for all such overrides, but we're already sloppy about it and you don't need
to
> fix existing cases.
> 
> (These comments apply throughout the CL)

Done. Made others private too as they're not called via a derived class pointer.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc:60: gi
On 2015/01/23 07:28:10, Peter Kasting wrote:
> This typo will break the compile.

Done.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_sync_promo_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_sync_promo_view.h:24: const char*
GetClassName() const override;
On 2015/01/23 07:28:10, Peter Kasting wrote:
> Nit: This should go after the StyledLabelListener override, to match the order
> of the parent class declarations above.

Done.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/keyword_hint_view.cc (left):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/keyword_hint_view.cc:24: 
On 2015/01/23 07:28:10, Peter Kasting wrote:
> Nit: Don't remove this (I generally try to separate sections of the .cc files
I
> own with double blank lines)

Done.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/keyword_hint_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/keyword_hint_view.h:44: // Views:
On 2015/01/23 07:28:10, Peter Kasting wrote:
> Nit: views::View:

Done. also made them private.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/location_bar/selected_keyword_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/location_bar/selected_keyword_view.h:29: // views::View:
On 2015/01/23 07:28:10, Peter Kasting wrote:
> This class inherits from IconLabelBubbleView, not views::View.

Done. also moved to private.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/login_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/login_view.h:28: // View:
On 2015/01/23 07:28:10, Peter Kasting wrote:
> Nit: views::View:

Done.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc:24: namespace {
On 2015/01/23 07:28:10, Peter Kasting wrote:
> Nit: Blank line below this

Done.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h:54: // Overridden
from views::View:
On 2015/01/23 07:28:10, Peter Kasting wrote:
> Nit: You're welcome, but not obligated, to remove the "Overridden from"s in
this
> file similarly to what you did in bookmark_bubble_view.h.

Done.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/tab_icon_view.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/tab_icon_view.h:36: // views::View:
On 2015/01/23 07:28:10, Peter Kasting wrote:
> Nit: This should refer to view::MenuButton instead.

Done. reordered & made them private.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/back_button.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/back_button.h:33: // NativeThemeDelegate:
On 2015/01/23 07:28:11, Peter Kasting wrote:
> This class doesn't inherit directly from NativeThemeDelegate, View, or
> LabelButton, so these should all be in a single "ToolbarButton:" section,
> ordered in the order in which ToolbarButton inherits from them.

Done.

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/home_button.h (right):

https://codereview.chromium.org/869453002/diff/120001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/home_button.h:28: // views::View:
On 2015/01/23 07:28:11, Peter Kasting wrote:
> Nit: Again, this should be "ToolbarButton:".

Done. moved all to private.

[Peter Kasting, 2015-01-24 02:21:00]

LGTM

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h (right):

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h:49: //
views::WidgetDelegate:
I think these next two methods both come via BubbleDelegateView, right?

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_editor_view.h (right):

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_editor_view.h:130: void Init();
Nit: Since there are now overrides above and below this, just move this down to
above Reset() (and in .cc file).

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
File chrome/browser/ui/views/find_bar_view.h (right):

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/find_bar_view.h:74: const char* GetClassName() const
override;
Can this method at least be private even if the other ones can't?  It would
probably go next to OnThemeChanged() (which needs its base class name comment
updated to say DropdownBarView)

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
File chrome/browser/ui/views/login_view.h (right):

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/login_view.h:32: // LoginModelObserver:
Nit: Prepend "password_manager::"

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h (right):

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h:65: //
ui::EventHandler:
Nit: Just nuke this heading and the blank line above it, since this override
comes by way of views::View.

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h:106:
scoped_ptr<OmniboxPopupModel> model_;
Nit: Move down to with other members

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/toolbar_action_view.h (right):

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_action_view.h:77: // views::View:
Nit: This should say "views::MenuButton:"

[oshima, 2015-01-26 19:48:18]

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h (right):

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h:49: //
views::WidgetDelegate:
On 2015/01/24 02:20:59, Peter Kasting wrote:
> I think these next two methods both come via BubbleDelegateView, right?

Done.

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
File chrome/browser/ui/views/bookmarks/bookmark_editor_view.h (right):

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/bookmarks/bookmark_editor_view.h:130: void Init();
On 2015/01/24 02:20:59, Peter Kasting wrote:
> Nit: Since there are now overrides above and below this, just move this down
to
> above Reset() (and in .cc file).

Done.

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
File chrome/browser/ui/views/find_bar_view.h (right):

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/find_bar_view.h:74: const char* GetClassName() const
override;
On 2015/01/24 02:20:59, Peter Kasting wrote:
> Can this method at least be private even if the other ones can't?  It would
> probably go next to OnThemeChanged() (which needs its base class name comment
> updated to say DropdownBarView)

Done.

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
File chrome/browser/ui/views/login_view.h (right):

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/login_view.h:32: // LoginModelObserver:
On 2015/01/24 02:20:59, Peter Kasting wrote:
> Nit: Prepend "password_manager::"

Done.

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h (right):

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h:65: //
ui::EventHandler:
On 2015/01/24 02:20:59, Peter Kasting wrote:
> Nit: Just nuke this heading and the blank line above it, since this override
> comes by way of views::View.

Done.

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h:106:
scoped_ptr<OmniboxPopupModel> model_;
On 2015/01/24 02:20:59, Peter Kasting wrote:
> Nit: Move down to with other members

Done.

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/toolbar_action_view.h (right):

https://codereview.chromium.org/869453002/diff/200001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_action_view.h:77: // views::View:
On 2015/01/24 02:20:59, Peter Kasting wrote:
> Nit: This should say "views::MenuButton:"

Done.

[oshima, 2015-01-26 19:50:27]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2015-01-26 19:52:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/869453002/220001

[commit-bot: I haz the power, 2015-01-26 20:50:19]

Committed patchset #5 (id:220001)

[commit-bot: I haz the power, 2015-01-26 20:52:22]

Patchset 5 (id:??) landed as
https://crrev.com/e7953145b624ee7426f1f62d35253486939dcce6
Cr-Commit-Position: refs/heads/master@{#313131}