Define class names for views class in c/b/ui/views

chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_POPUP_CONTENTS_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_POPUP_CONTENTS_VIEW_H_
 
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/ui/omnibox/omnibox_popup_model.h"
 #include "chrome/browser/ui/omnibox/omnibox_popup_view.h"
@@ skipping 22 matching lines @@
                                   OmniboxView* omnibox_view,
                                   OmniboxEditModel* edit_model,
                                   LocationBarView* location_bar_view);
 
   // Returns the bounds the popup should be shown at. This is the display bounds
   // and includes offsets for the dropshadow which this view's border renders.
   gfx::Rect GetPopupBounds() const;
 
   virtual void LayoutChildren();
 
-  // Overridden from OmniboxPopupView:
+  // OmniboxPopupView:
   bool IsOpen() const override;
   void InvalidateLine(size_t line) override;
   void UpdatePopupAppearance() override;
   gfx::Rect GetTargetBounds() override;
   void PaintUpdatesNow() override;
   void OnDragCanceled() override;
 
-  // Overridden from gfx::AnimationDelegate:
+  // gfx::AnimationDelegate:
   void AnimationProgressed(const gfx::Animation* animation) override;
 
-  // Overridden from views::View:
+  // views::View:
   void Layout() override;
   views::View* GetTooltipHandlerForPoint(const gfx::Point& point) override;
   bool OnMousePressed(const ui::MouseEvent& event) override;
   bool OnMouseDragged(const ui::MouseEvent& event) override;
   void OnMouseReleased(const ui::MouseEvent& event) override;
   void OnMouseCaptureLost() override;
   void OnMouseMoved(const ui::MouseEvent& event) override;
   void OnMouseEntered(const ui::MouseEvent& event) override;
   void OnMouseExited(const ui::MouseEvent& event) override;
 
-  // Overridden from ui::EventHandler:
+  // ui::EventHandler:

[Peter Kasting, 2015/01/24 02:20:59]

Nit: Just nuke this heading and the blank line above it, since this override
comes by way of views::View.

[oshima, 2015/01/26 19:48:18]

Done.

   void OnGestureEvent(ui::GestureEvent* event) override;
 
   bool IsSelectedIndex(size_t index) const;
   bool IsHoveredIndex(size_t index) const;
   gfx::Image GetIconIfExtensionMatch(size_t index) const;
   bool IsStarredMatch(const AutocompleteMatch& match) const;
 
   int max_match_contents_width() const {
     return max_match_contents_width_;
   }
 
  protected:
   OmniboxPopupContentsView(const gfx::FontList& font_list,
                            OmniboxView* omnibox_view,
                            OmniboxEditModel* edit_model,
                            LocationBarView* location_bar_view);
   ~OmniboxPopupContentsView() override;
 
   LocationBarView* location_bar_view() { return location_bar_view_; }
 
   virtual void PaintResultViews(gfx::Canvas* canvas);
 
   // Calculates the height needed to show all the results in the model.
   virtual int CalculatePopupHeight();
   virtual OmniboxResultView* CreateResultView(int model_index,
                                               const gfx::FontList& font_list);
 
-  // Overridden from views::View:
+ private:
+  class AutocompletePopupWidget;
+
+  // views::View:
+  const char* GetClassName() const override;
   void OnPaint(gfx::Canvas* canvas) override;
   // This method should not be triggered directly as we paint our children
   // in an un-conventional way inside OnPaint. We use a separate canvas to
   // paint the children. Hence we override this method to a no-op so that
   // the view hierarchy does not "accidentally" trigger this.
   void PaintChildren(gfx::Canvas* canvas,
                      const views::CullSet& cull_set) override;
 
   scoped_ptr<OmniboxPopupModel> model_;

[Peter Kasting, 2015/01/24 02:20:59]

Nit: Move down to with other members

[oshima, 2015/01/26 19:48:18]

Done.

 
- private:
-  class AutocompletePopupWidget;
-
   // views::ViewTargeterDelegate:
   views::View* TargetForRect(views::View* root, const gfx::Rect& rect) override;
 
   // Call immediately after construction.
   void Init();
 
   // Returns true if the model has a match at the specified index.
   bool HasMatchAt(size_t index) const;
 
   // Returns the match at the specified index within the popup model.
@@ skipping 58 matching lines @@
 
   // When the dropdown is not wide enough while displaying postfix suggestions,
   // we use the width of widest match contents to shift the suggestions so that
   // the widest suggestion just reaches the end edge.
   int max_match_contents_width_;
 
   DISALLOW_COPY_AND_ASSIGN(OmniboxPopupContentsView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_POPUP_CONTENTS_VIEW_H_