Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

Issue 869453002: Define class names for views class in c/b/ui/views (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: addressed comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 28 matching lines...) Expand all
39 Profile* profile, 39 Profile* profile,
40 const GURL& url, 40 const GURL& url,
41 bool newly_bookmarked); 41 bool newly_bookmarked);
42 42
43 static bool IsShowing(); 43 static bool IsShowing();
44 44
45 static void Hide(); 45 static void Hide();
46 46
47 ~BookmarkBubbleView() override; 47 ~BookmarkBubbleView() override;
48 48
49 // views::BubbleDelegateView method. 49 // views::WidgetDelegate:
Peter Kasting 2015/01/24 02:20:59 I think these next two methods both come via Bubbl
oshima 2015/01/26 19:48:18 Done.
50 views::View* GetInitiallyFocusedView() override;
51
52 // views::WidgetDelegate method.
53 void WindowClosing() override; 50 void WindowClosing() override;
54 51
55 // views::View method. 52 // views::View:
56 bool AcceleratorPressed(const ui::Accelerator& accelerator) override; 53 bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
57 54
58 protected: 55 protected:
59 // views::BubbleDelegateView method. 56 // views::BubbleDelegateView method.
60 void Init() override; 57 void Init() override;
61 58
62 private: 59 private:
63 friend class BookmarkBubbleViewTest; 60 friend class BookmarkBubbleViewTest;
64 FRIEND_TEST_ALL_PREFIXES(BookmarkBubbleViewTest, SyncPromoSignedIn); 61 FRIEND_TEST_ALL_PREFIXES(BookmarkBubbleViewTest, SyncPromoSignedIn);
65 FRIEND_TEST_ALL_PREFIXES(BookmarkBubbleViewTest, SyncPromoNotSignedIn); 62 FRIEND_TEST_ALL_PREFIXES(BookmarkBubbleViewTest, SyncPromoNotSignedIn);
66 63
64 // views::BubbleDelegateView:
65 const char* GetClassName() const override;
66 views::View* GetInitiallyFocusedView() override;
67
67 // Creates a BookmarkBubbleView. 68 // Creates a BookmarkBubbleView.
68 BookmarkBubbleView(views::View* anchor_view, 69 BookmarkBubbleView(views::View* anchor_view,
69 BookmarkBubbleViewObserver* observer, 70 BookmarkBubbleViewObserver* observer,
70 scoped_ptr<BookmarkBubbleDelegate> delegate, 71 scoped_ptr<BookmarkBubbleDelegate> delegate,
71 Profile* profile, 72 Profile* profile,
72 const GURL& url, 73 const GURL& url,
73 bool newly_bookmarked); 74 bool newly_bookmarked);
74 75
75 // Returns the title to display. 76 // Returns the title to display.
76 base::string16 GetTitle(); 77 base::string16 GetTitle();
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 // When the destructor is invoked should the bookmark be removed? 137 // When the destructor is invoked should the bookmark be removed?
137 bool remove_bookmark_; 138 bool remove_bookmark_;
138 139
139 // When the destructor is invoked should edits be applied? 140 // When the destructor is invoked should edits be applied?
140 bool apply_edits_; 141 bool apply_edits_;
141 142
142 DISALLOW_COPY_AND_ASSIGN(BookmarkBubbleView); 143 DISALLOW_COPY_AND_ASSIGN(BookmarkBubbleView);
143 }; 144 };
144 145
145 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_ 146 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698