Define class names for views class in c/b/ui/views

chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_INSTRUCTIONS_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_INSTRUCTIONS_VIEW_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "ui/views/context_menu_controller.h"
@@ skipping 13 matching lines @@
 // with a link to import bookmarks. Clicking the link results in notifying the
 // delegate.
 class BookmarkBarInstructionsView : public views::View,
                                     public views::LinkListener,
                                     public views::ContextMenuController {
  public:
   explicit BookmarkBarInstructionsView(
       BookmarkBarInstructionsDelegate* delegate);
 
   // views::View overrides.
+  const char* GetClassName() const override;

[Peter Kasting, 2015/01/23 07:28:10]

In theory, these are listed in the same order that they're listed in the base
class declaration.

In practice we probably already don't get this right in a lot of places, but it
would be nice not to introduce new instances thereof.

Also (and this will probably make your life easier in this regard), all the
GetClassName() overrides you're adding should be private, since no one needs to
call them via a derived class pointer.  Again, we should have been doing this
for all such overrides, but we're already sloppy about it and you don't need to
fix existing cases.

(These comments apply throughout the CL)

[oshima, 2015/01/24 01:23:07]

Done. Made others private too as they're not called via a derived class pointer.

   gfx::Size GetPreferredSize() const override;
   void Layout() override;
   void OnThemeChanged() override;
   void ViewHierarchyChanged(
       const ViewHierarchyChangedDetails& details) override;
   void GetAccessibleState(ui::AXViewState* state) override;
 
   // views::LinkListener overrides.
   void LinkClicked(views::Link* source, int event_flags) override;
 
@@ skipping 14 matching lines @@
   int baseline_;
 
   // Have the colors of the child views been updated? This is initially false
   // and set to true once we have a valid ThemeProvider.
   bool updated_colors_;
 
   DISALLOW_COPY_AND_ASSIGN(BookmarkBarInstructionsView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_INSTRUCTIONS_VIEW_H_