Remove the dependency of Zone on Isolate

Remove the dependency of Zone on Isolate

Along the way:
- Thread isolate parameter explicitly through code that used to
  rely on getting it from the zone.
- Canonicalize the parameter position of isolate and zone for
  affected code
- Change Hydrogen New<> instruction templates to automatically
  pass isolate

R=mstarzinger@chromium.org
LOG=N

Committed: https://crrev.com/c7b09aac317dd810d29b82061973199b80363b65
Cr-Commit-Position: refs/heads/master@{#26252}

[danno, 2015-01-23 12:05:53]

danno@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[danno, 2015-01-23 12:06:34]

PTAL

[dcarney, 2015-01-23 13:02:18]

dcarney@chromium.org changed reviewers:
+ dcarney@chromium.org

[dcarney, 2015-01-23 13:02:18]

The CQ bit was checked by dcarney@chromium.org

[dcarney, 2015-01-23 13:02:19]

lgtm

[commit-bot: I haz the power, 2015-01-23 13:03:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/868883002/100001

[Michael Starzinger, 2015-01-23 13:04:15]

The CQ bit was unchecked by mstarzinger@chromium.org

[danno, 2015-01-23 13:04:20]

The CQ bit was unchecked by danno@chromium.org

[Michael Starzinger, 2015-01-23 14:21:11]

LGTM if comments are addressed.

https://codereview.chromium.org/868883002/diff/100001/src/ast.h
File src/ast.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/ast.h#newcode3171
src/ast.h:3171: explicit AstNodeFactory(Isolate* isolate, AstValueFactory*
ast_value_factory)
nit: The AstNodeFactory doesn't seem to use the Isolate, is there a particular
reason we need to pass it in?

https://codereview.chromium.org/868883002/diff/100001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/868883002/diff/100001/src/compiler.cc#newcode765
src/compiler.cc:765: if (!AstNumbering::Renumber(info->isolate(), info->zone(),
info->function()))
nit: Can we put curly braces around body since conditional span more than one
line now?

https://codereview.chromium.org/868883002/diff/100001/src/compiler.cc#newcode...
src/compiler.cc:1562: : name_(name), info_(info), zone_() {
nit: Can we drop explicit initializer call?

https://codereview.chromium.org/868883002/diff/100001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/compiler.h#newcode532
src/compiler.h:532: : CompilationInfo(script, &zone_), zone_() {}
nit: It should be possible to just drop the initializer call to zone_ now since
the implicit initializer is used anyways. Applies here and three more times
below.

https://codereview.chromium.org/868883002/diff/100001/src/compiler/graph-buil...
File src/compiler/graph-builder.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/compiler/graph-buil...
src/compiler/graph-builder.h:137: Isolate* isolate() const { return isolate_; }
Can be dropped since it now just overrides GraphBuilder::isolate anyways.

https://codereview.chromium.org/868883002/diff/100001/src/compiler/graph-buil...
src/compiler/graph-builder.h:157: Isolate* isolate_;
Can be dropped now since it shadows GraphBuilder::isolate_ now.

https://codereview.chromium.org/868883002/diff/100001/src/compiler/ia32/instr...
File src/compiler/ia32/instruction-selector-ia32.cc (right):

https://codereview.chromium.org/868883002/diff/100001/src/compiler/ia32/instr...
src/compiler/ia32/instruction-selector-ia32.cc:34: return
!value.handle()->GetIsolate()->heap()->InNewSpace(
nit: Can we pull out the Isolate into a local variable here for readability?

https://codereview.chromium.org/868883002/diff/100001/src/compiler/typer.h
File src/compiler/typer.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/compiler/typer.h#ne...
src/compiler/typer.h:24: explicit Typer(Isolate* isolate, Graph* graph,
MaybeHandle<Context> context);
nit: No longer needs to be marked "explicit".

https://codereview.chromium.org/868883002/diff/100001/src/compiler/zone-pool.cc
File src/compiler/zone-pool.cc (right):

https://codereview.chromium.org/868883002/diff/100001/src/compiler/zone-pool....
src/compiler/zone-pool.cc:68: ZonePool::ZonePool(Isolate* isolate)
remark: Looks like we can also drop the Isolate parameter from the ZonePool now,
but that is for a separate CL, just wanted to point it out.

https://codereview.chromium.org/868883002/diff/100001/src/full-codegen.h
File src/full-codegen.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/full-codegen.h#newc...
src/full-codegen.h:32: explicit BreakableStatementChecker(Isolate* isolate,
Zone* zone)
nit: No longer needs to be marked "explicit" now.

https://codereview.chromium.org/868883002/diff/100001/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/hydrogen.h#newcode2517
src/hydrogen.h:2517: Isolate* isolate() const { return lookup_.isolate(); }
nit: Change looks unnecessary.

https://codereview.chromium.org/868883002/diff/100001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/868883002/diff/100001/src/isolate.cc#newcode1647
src/isolate.cc:1647: runtime_zone_(),
nit: Explicit initializer call could be dropped.

https://codereview.chromium.org/868883002/diff/100001/src/json-parser.h
File src/json-parser.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/json-parser.h#newco...
src/json-parser.h:35: zone_(),
nit: Explicit initializer call could be dropped.

https://codereview.chromium.org/868883002/diff/100001/src/lithium-allocator.cc
File src/lithium-allocator.cc (right):

https://codereview.chromium.org/868883002/diff/100001/src/lithium-allocator.c...
src/lithium-allocator.cc:514: : zone_(),
nit: Explicit initializer call could be dropped.

https://codereview.chromium.org/868883002/diff/100001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/preparser.h#newcode597
src/preparser.h:597: Isolate* isolate() const { return isolate_; }
nit: Could we move this up to around line 300 near the other getters for
readability?

https://codereview.chromium.org/868883002/diff/100001/src/prettyprinter.h
File src/prettyprinter.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/prettyprinter.h#new...
src/prettyprinter.h:16: explicit CallPrinter(Isolate* isolate, Zone* zone);
nit: No longer needs to be marked "explicit".

https://codereview.chromium.org/868883002/diff/100001/src/prettyprinter.h#new...
src/prettyprinter.h:55: explicit PrettyPrinter(Isolate* isolate, Zone* zone);
nit: No longer needs to be marked "explicit".

https://codereview.chromium.org/868883002/diff/100001/src/prettyprinter.h#new...
src/prettyprinter.h:101: explicit AstPrinter(Isolate* isolate, Zone* zone);
nit: No longer needs to be marked "explicit".

https://codereview.chromium.org/868883002/diff/100001/src/regexp-macro-assemb...
File src/regexp-macro-assembler-tracer.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/regexp-macro-assemb...
src/regexp-macro-assembler-tracer.h:14: explicit
RegExpMacroAssemblerTracer(Isolate* isolate,
nit: No longer needs to be marked "explicit".

https://codereview.chromium.org/868883002/diff/100001/src/regexp-macro-assemb...
File src/regexp-macro-assembler.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/regexp-macro-assemb...
src/regexp-macro-assembler.h:46: explicit RegExpMacroAssembler(Isolate* isolate,
Zone* zone);
nit: No longer needs to be marked "explicit".

https://codereview.chromium.org/868883002/diff/100001/src/regexp-macro-assemb...
src/regexp-macro-assembler.h:190: explicit NativeRegExpMacroAssembler(Isolate*
isolate, Zone* zone);
nit: No longer needs to be marked "explicit".

https://codereview.chromium.org/868883002/diff/100001/test/cctest/cctest.h
File test/cctest/cctest.h (right):

https://codereview.chromium.org/868883002/diff/100001/test/cctest/cctest.h#ne...
test/cctest/cctest.h:580: HandleAndZoneScope() : main_zone_() {}
nit: Explicit initializer call can be dropped.

https://codereview.chromium.org/868883002/diff/100001/test/cctest/compiler/gr...
File test/cctest/compiler/graph-builder-tester.h (right):

https://codereview.chromium.org/868883002/diff/100001/test/cctest/compiler/gr...
test/cctest/compiler/graph-builder-tester.h:25: explicit
DirectGraphBuilder(Isolate* isolate, Graph* graph)
nit: No longer needs to be marked "explicit".

https://codereview.chromium.org/868883002/diff/100001/test/cctest/compiler/te...
File test/cctest/compiler/test-js-constant-cache.cc (right):

https://codereview.chromium.org/868883002/diff/100001/test/cctest/compiler/te...
test/cctest/compiler/test-js-constant-cache.cc:20: explicit
JSCacheTesterHelper(Isolate* isolate, Zone* zone)
nit: No longer needs to be marked "explicit".

https://codereview.chromium.org/868883002/diff/100001/test/unittests/test-uti...
File test/unittests/test-utils.h (right):

https://codereview.chromium.org/868883002/diff/100001/test/unittests/test-uti...
test/unittests/test-utils.h:95: TestWithZone() : zone_() {}
nit: Explicit initializer call shouldn't be needed anymore.

[danno, 2015-01-23 14:45:21]

Feedback addressed, landing via CQ

https://codereview.chromium.org/868883002/diff/100001/src/ast.h
File src/ast.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/ast.h#newcode3171
src/ast.h:3171: explicit AstNodeFactory(Isolate* isolate, AstValueFactory*
ast_value_factory)
On 2015/01/23 14:21:10, Michael Starzinger wrote:
> nit: The AstNodeFactory doesn't seem to use the Isolate, is there a particular
> reason we need to pass it in?

Done.

https://codereview.chromium.org/868883002/diff/100001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/868883002/diff/100001/src/compiler.cc#newcode765
src/compiler.cc:765: if (!AstNumbering::Renumber(info->isolate(), info->zone(),
info->function()))
On 2015/01/23 14:21:10, Michael Starzinger wrote:
> nit: Can we put curly braces around body since conditional span more than one
> line now?

Done.

https://codereview.chromium.org/868883002/diff/100001/src/compiler.cc#newcode...
src/compiler.cc:1562: : name_(name), info_(info), zone_() {
On 2015/01/23 14:21:10, Michael Starzinger wrote:
> nit: Can we drop explicit initializer call?

Done.

https://codereview.chromium.org/868883002/diff/100001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/compiler.h#newcode532
src/compiler.h:532: : CompilationInfo(script, &zone_), zone_() {}
On 2015/01/23 14:21:10, Michael Starzinger wrote:
> nit: It should be possible to just drop the initializer call to zone_ now
since
> the implicit initializer is used anyways. Applies here and three more times
> below.

Done.

https://codereview.chromium.org/868883002/diff/100001/src/compiler/graph-buil...
File src/compiler/graph-builder.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/compiler/graph-buil...
src/compiler/graph-builder.h:137: Isolate* isolate() const { return isolate_; }
On 2015/01/23 14:21:10, Michael Starzinger wrote:
> Can be dropped since it now just overrides GraphBuilder::isolate anyways.

Done.

https://codereview.chromium.org/868883002/diff/100001/src/compiler/graph-buil...
src/compiler/graph-builder.h:157: Isolate* isolate_;
On 2015/01/23 14:21:10, Michael Starzinger wrote:
> Can be dropped now since it shadows GraphBuilder::isolate_ now.

Done.

https://codereview.chromium.org/868883002/diff/100001/src/compiler/ia32/instr...
File src/compiler/ia32/instruction-selector-ia32.cc (right):

https://codereview.chromium.org/868883002/diff/100001/src/compiler/ia32/instr...
src/compiler/ia32/instruction-selector-ia32.cc:34: return
!value.handle()->GetIsolate()->heap()->InNewSpace(
On 2015/01/23 14:21:10, Michael Starzinger wrote:
> nit: Can we pull out the Isolate into a local variable here for readability?

Done.

https://codereview.chromium.org/868883002/diff/100001/src/compiler/typer.h
File src/compiler/typer.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/compiler/typer.h#ne...
src/compiler/typer.h:24: explicit Typer(Isolate* isolate, Graph* graph,
MaybeHandle<Context> context);
On 2015/01/23 14:21:10, Michael Starzinger wrote:
> nit: No longer needs to be marked "explicit".

Done.

https://codereview.chromium.org/868883002/diff/100001/src/compiler/zone-pool.cc
File src/compiler/zone-pool.cc (right):

https://codereview.chromium.org/868883002/diff/100001/src/compiler/zone-pool....
src/compiler/zone-pool.cc:68: ZonePool::ZonePool(Isolate* isolate)
On 2015/01/23 14:21:10, Michael Starzinger wrote:
> remark: Looks like we can also drop the Isolate parameter from the ZonePool
now,
> but that is for a separate CL, just wanted to point it out.

Done.

https://codereview.chromium.org/868883002/diff/100001/src/full-codegen.h
File src/full-codegen.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/full-codegen.h#newc...
src/full-codegen.h:32: explicit BreakableStatementChecker(Isolate* isolate,
Zone* zone)
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: No longer needs to be marked "explicit" now.

Done.

https://codereview.chromium.org/868883002/diff/100001/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/hydrogen.h#newcode2517
src/hydrogen.h:2517: Isolate* isolate() const { return lookup_.isolate(); }
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: Change looks unnecessary.

Needs to be public, it was private before.

https://codereview.chromium.org/868883002/diff/100001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/868883002/diff/100001/src/isolate.cc#newcode1647
src/isolate.cc:1647: runtime_zone_(),
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: Explicit initializer call could be dropped.

Done.

https://codereview.chromium.org/868883002/diff/100001/src/json-parser.h
File src/json-parser.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/json-parser.h#newco...
src/json-parser.h:35: zone_(),
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: Explicit initializer call could be dropped.

Done.

https://codereview.chromium.org/868883002/diff/100001/src/lithium-allocator.cc
File src/lithium-allocator.cc (right):

https://codereview.chromium.org/868883002/diff/100001/src/lithium-allocator.c...
src/lithium-allocator.cc:514: : zone_(),
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: Explicit initializer call could be dropped.

Done.

https://codereview.chromium.org/868883002/diff/100001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/preparser.h#newcode597
src/preparser.h:597: Isolate* isolate() const { return isolate_; }
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: Could we move this up to around line 300 near the other getters for
> readability?

Done.

https://codereview.chromium.org/868883002/diff/100001/src/prettyprinter.h
File src/prettyprinter.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/prettyprinter.h#new...
src/prettyprinter.h:16: explicit CallPrinter(Isolate* isolate, Zone* zone);
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: No longer needs to be marked "explicit".

Done.

https://codereview.chromium.org/868883002/diff/100001/src/prettyprinter.h#new...
src/prettyprinter.h:55: explicit PrettyPrinter(Isolate* isolate, Zone* zone);
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: No longer needs to be marked "explicit".

Done.

https://codereview.chromium.org/868883002/diff/100001/src/prettyprinter.h#new...
src/prettyprinter.h:101: explicit AstPrinter(Isolate* isolate, Zone* zone);
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: No longer needs to be marked "explicit".

Done.

https://codereview.chromium.org/868883002/diff/100001/src/regexp-macro-assemb...
File src/regexp-macro-assembler-tracer.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/regexp-macro-assemb...
src/regexp-macro-assembler-tracer.h:14: explicit
RegExpMacroAssemblerTracer(Isolate* isolate,
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: No longer needs to be marked "explicit".

Done.

https://codereview.chromium.org/868883002/diff/100001/src/regexp-macro-assemb...
File src/regexp-macro-assembler.h (right):

https://codereview.chromium.org/868883002/diff/100001/src/regexp-macro-assemb...
src/regexp-macro-assembler.h:46: explicit RegExpMacroAssembler(Isolate* isolate,
Zone* zone);
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: No longer needs to be marked "explicit".

Done.

https://codereview.chromium.org/868883002/diff/100001/src/regexp-macro-assemb...
src/regexp-macro-assembler.h:190: explicit NativeRegExpMacroAssembler(Isolate*
isolate, Zone* zone);
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: No longer needs to be marked "explicit".

Done.

https://codereview.chromium.org/868883002/diff/100001/test/cctest/cctest.h
File test/cctest/cctest.h (right):

https://codereview.chromium.org/868883002/diff/100001/test/cctest/cctest.h#ne...
test/cctest/cctest.h:580: HandleAndZoneScope() : main_zone_() {}
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: Explicit initializer call can be dropped.

Done.

https://codereview.chromium.org/868883002/diff/100001/test/cctest/compiler/gr...
File test/cctest/compiler/graph-builder-tester.h (right):

https://codereview.chromium.org/868883002/diff/100001/test/cctest/compiler/gr...
test/cctest/compiler/graph-builder-tester.h:25: explicit
DirectGraphBuilder(Isolate* isolate, Graph* graph)
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: No longer needs to be marked "explicit".

Done.

https://codereview.chromium.org/868883002/diff/100001/test/cctest/compiler/te...
File test/cctest/compiler/test-js-constant-cache.cc (right):

https://codereview.chromium.org/868883002/diff/100001/test/cctest/compiler/te...
test/cctest/compiler/test-js-constant-cache.cc:20: explicit
JSCacheTesterHelper(Isolate* isolate, Zone* zone)
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: No longer needs to be marked "explicit".

Done.

https://codereview.chromium.org/868883002/diff/100001/test/unittests/test-uti...
File test/unittests/test-utils.h (right):

https://codereview.chromium.org/868883002/diff/100001/test/unittests/test-uti...
test/unittests/test-utils.h:95: TestWithZone() : zone_() {}
On 2015/01/23 14:21:11, Michael Starzinger wrote:
> nit: Explicit initializer call shouldn't be needed anymore.

Done.

[danno, 2015-01-23 14:45:26]

Feedback addressed, landing via CQ

[danno, 2015-01-23 14:45:47]

The CQ bit was checked by danno@chromium.org

[commit-bot: I haz the power, 2015-01-23 14:46:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/868883002/120001

[danno, 2015-01-23 14:46:29]

The CQ bit was unchecked by danno@chromium.org

[danno, 2015-01-23 14:48:48]

The CQ bit was checked by danno@chromium.org

[danno, 2015-01-23 14:49:09]

Patchset #5 (id:80001) has been deleted

[danno, 2015-01-23 14:49:18]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2015-01-23 14:49:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/868883002/140001

[danno, 2015-01-23 14:49:48]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2015-01-23 15:19:47]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2015-01-23 15:20:09]

Patchset 5 (id:??) landed as
https://crrev.com/c7b09aac317dd810d29b82061973199b80363b65
Cr-Commit-Position: refs/heads/master@{#26252}