Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: test/cctest/compiler/test-js-constant-cache.cc

Issue 868883002: Remove the dependency of Zone on Isolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix compilation issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/assembler.h" 7 #include "src/assembler.h"
8 #include "src/compiler/js-graph.h" 8 #include "src/compiler/js-graph.h"
9 #include "src/compiler/node-properties-inl.h" 9 #include "src/compiler/node-properties-inl.h"
10 #include "src/compiler/typer.h" 10 #include "src/compiler/typer.h"
11 #include "src/types.h" 11 #include "src/types.h"
12 #include "test/cctest/cctest.h" 12 #include "test/cctest/cctest.h"
13 #include "test/cctest/compiler/value-helper.h" 13 #include "test/cctest/compiler/value-helper.h"
14 14
15 using namespace v8::internal; 15 using namespace v8::internal;
16 using namespace v8::internal::compiler; 16 using namespace v8::internal::compiler;
17 17
18 class JSCacheTesterHelper { 18 class JSCacheTesterHelper {
19 protected: 19 protected:
20 explicit JSCacheTesterHelper(Zone* zone) 20 JSCacheTesterHelper(Isolate* isolate, Zone* zone)
21 : main_graph_(zone), 21 : main_graph_(zone),
22 main_common_(zone), 22 main_common_(zone),
23 main_javascript_(zone), 23 main_javascript_(zone),
24 main_typer_(&main_graph_, MaybeHandle<Context>()), 24 main_typer_(isolate, &main_graph_, MaybeHandle<Context>()),
25 main_machine_(zone) {} 25 main_machine_(zone) {}
26 Graph main_graph_; 26 Graph main_graph_;
27 CommonOperatorBuilder main_common_; 27 CommonOperatorBuilder main_common_;
28 JSOperatorBuilder main_javascript_; 28 JSOperatorBuilder main_javascript_;
29 Typer main_typer_; 29 Typer main_typer_;
30 MachineOperatorBuilder main_machine_; 30 MachineOperatorBuilder main_machine_;
31 }; 31 };
32 32
33 33
34 // TODO(dcarney): JSConstantCacheTester inherits from JSGraph??? 34 // TODO(dcarney): JSConstantCacheTester inherits from JSGraph???
35 class JSConstantCacheTester : public HandleAndZoneScope, 35 class JSConstantCacheTester : public HandleAndZoneScope,
36 public JSCacheTesterHelper, 36 public JSCacheTesterHelper,
37 public JSGraph { 37 public JSGraph {
38 public: 38 public:
39 JSConstantCacheTester() 39 JSConstantCacheTester()
40 : JSCacheTesterHelper(main_zone()), 40 : JSCacheTesterHelper(main_isolate(), main_zone()),
41 JSGraph(&main_graph_, &main_common_, &main_javascript_, 41 JSGraph(main_isolate(), &main_graph_, &main_common_, &main_javascript_,
42 &main_machine_) { 42 &main_machine_) {
43 main_graph_.SetStart(main_graph_.NewNode(common()->Start(0))); 43 main_graph_.SetStart(main_graph_.NewNode(common()->Start(0)));
44 main_graph_.SetEnd(main_graph_.NewNode(common()->End())); 44 main_graph_.SetEnd(main_graph_.NewNode(common()->End()));
45 main_typer_.Run(); 45 main_typer_.Run();
46 } 46 }
47 47
48 Type* upper(Node* node) { return NodeProperties::GetBounds(node).upper; } 48 Type* upper(Node* node) { return NodeProperties::GetBounds(node).upper; }
49 49
50 Handle<Object> handle(Node* node) { 50 Handle<Object> handle(Node* node) {
51 CHECK_EQ(IrOpcode::kHeapConstant, node->opcode()); 51 CHECK_EQ(IrOpcode::kHeapConstant, node->opcode());
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 T.Constant(1.11), 465 T.Constant(1.11),
466 T.ExternalConstant(ExternalReference::address_of_one_half())}; 466 T.ExternalConstant(ExternalReference::address_of_one_half())};
467 467
468 NodeVector nodes(T.main_zone()); 468 NodeVector nodes(T.main_zone());
469 T.GetCachedNodes(&nodes); 469 T.GetCachedNodes(&nodes);
470 470
471 for (size_t i = 0; i < arraysize(constants); i++) { 471 for (size_t i = 0; i < arraysize(constants); i++) {
472 CHECK(Contains(&nodes, constants[i])); 472 CHECK(Contains(&nodes, constants[i]));
473 } 473 }
474 } 474 }
OLDNEW
« no previous file with comments | « test/cctest/compiler/test-instruction.cc ('k') | test/cctest/compiler/test-js-context-specialization.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698