Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: src/scopes.h

Issue 868883002: Remove the dependency of Zone on Isolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix compilation issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/scopeinfo.cc ('k') | src/scopes.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scopes.h
diff --git a/src/scopes.h b/src/scopes.h
index 8d790068783c20e681248972c91dbce176d1848f..98a3014dbcbcad75ee4b9080c9c20ab89888c5e7 100644
--- a/src/scopes.h
+++ b/src/scopes.h
@@ -72,16 +72,16 @@ class Scope: public ZoneObject {
// ---------------------------------------------------------------------------
// Construction
- Scope(Scope* outer_scope, ScopeType scope_type,
- AstValueFactory* value_factory, Zone* zone);
+ Scope(Isolate* isolate, Zone* zone, Scope* outer_scope, ScopeType scope_type,
+ AstValueFactory* value_factory);
// Compute top scope and allocate variables. For lazy compilation the top
// scope only contains the single lazily compiled function, so this
// doesn't re-allocate variables repeatedly.
static bool Analyze(CompilationInfo* info);
- static Scope* DeserializeScopeChain(Context* context, Scope* script_scope,
- Zone* zone);
+ static Scope* DeserializeScopeChain(Isolate* isolate, Zone* zone,
+ Context* context, Scope* script_scope);
// The scope name is only used for printing/debugging.
void SetScopeName(const AstRawString* scope_name) {
@@ -95,6 +95,7 @@ class Scope: public ZoneObject {
// tree and its children are reparented.
Scope* FinalizeBlockScope();
+ Isolate* isolate() const { return isolate_; }
Zone* zone() const { return zone_; }
// ---------------------------------------------------------------------------
@@ -651,13 +652,13 @@ class Scope: public ZoneObject {
private:
// Construct a scope based on the scope info.
- Scope(Scope* inner_scope, ScopeType type, Handle<ScopeInfo> scope_info,
- AstValueFactory* value_factory, Zone* zone);
+ Scope(Isolate* isolate, Zone* zone, Scope* inner_scope, ScopeType type,
+ Handle<ScopeInfo> scope_info, AstValueFactory* value_factory);
// Construct a catch scope with a binding for the name.
- Scope(Scope* inner_scope,
+ Scope(Isolate* isolate, Zone* zone, Scope* inner_scope,
const AstRawString* catch_variable_name,
- AstValueFactory* value_factory, Zone* zone);
+ AstValueFactory* value_factory);
void AddInnerScope(Scope* inner_scope) {
if (inner_scope != NULL) {
« no previous file with comments | « src/scopeinfo.cc ('k') | src/scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698