Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: public/web/WebServiceWorkerContextClient.h

Issue 868233006: [ServiceWorker] Cleanup to remove old focus() code kept to not break Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_focus_client
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/platform/WebServiceWorkerClientFocusCallback.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebServiceWorkerContextClient.h
diff --git a/public/web/WebServiceWorkerContextClient.h b/public/web/WebServiceWorkerContextClient.h
index 46ee8928f26b53b7249160c2eebf67aee45b165c..9632fdd02785ee8b40b6b43925d0028bc4b2409c 100644
--- a/public/web/WebServiceWorkerContextClient.h
+++ b/public/web/WebServiceWorkerContextClient.h
@@ -33,7 +33,6 @@
#include "WebWorkerPermissionClientProxy.h"
#include "public/platform/WebMessagePortChannel.h"
-#include "public/platform/WebServiceWorkerClientFocusCallback.h"
#include "public/platform/WebServiceWorkerClientsClaimCallbacks.h"
#include "public/platform/WebServiceWorkerClientsInfo.h"
#include "public/platform/WebServiceWorkerEventResult.h"
@@ -172,11 +171,6 @@ public:
// Ownership of the passed callbacks is transferred to the callee, callee
// should delete the callback after calling either onSuccess or onError.
- // FIXME: delete this method as soon as Chromium stop calling it.
- virtual void focus(int clientID, WebServiceWorkerClientFocusCallback*) { BLINK_ASSERT_NOT_REACHED(); }
-
- // Ownership of the passed callbacks is transferred to the callee, callee
dominicc (has gone to gerrit) 2015/02/02 18:25:36 Why not keep the comment about ownership?
mlamouri (slow - plz ping) 2015/02/06 14:05:47 The comment is still, it's just a bit above. The d
- // should delete the callback after calling either onSuccess or onError.
virtual void focus(int cliendID, WebServiceWorkerClientCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
};
« no previous file with comments | « public/platform/WebServiceWorkerClientFocusCallback.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698