Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 867883006: Revert of Roll libvpx: cc9c0c:5da40c (Closed)

Created:
5 years, 11 months ago by yoichio
Modified:
5 years, 10 months ago
Reviewers:
Johann, Tom Finegan, Yaowu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll libvpx: cc9c0c:5da40c (patchset #1 id:1 of https://codereview.chromium.org/883503002/) Reason for revert: Crashed in Win Vista test. https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/52878 Original issue's description: > Roll libvpx: cc9c0c:5da40c > > Cherry-pick potential divide-by-zero fix > https://codereview.chromium.org/877783004 > > This includes remnants of an attempt to turn on AVX2. That failed and the > critical parts have been reverted. However, the attempt revealed some necessary > changes which have been kept for the next attempt. These constitute a no-op for > this particular roll. > > Enable AVX2: > https://codereview.chromium.org/863143002 > > Fix GN build: > https://codereview.chromium.org/865893004 > https://codereview.chromium.org/817293008 > https://codereview.chromium.org/866273003 > > Fix cpu detection: > https://codereview.chromium.org/864393002 > > Disable AVX2: > https://codereview.chromium.org/880513003 > > R=tomfinegan@chromium.org > R=yaowu@chromium.org > BUG=396572 > > Committed: https://crrev.com/09c4610490c2efb0e14a96a12250625bcca94dd6 > Cr-Commit-Position: refs/heads/master@{#313182} TBR=tomfinegan@chromium.org,yaowu@chromium.org,johannkoenig@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=396572

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
yoichio
Created Revert of Roll libvpx: cc9c0c:5da40c
5 years, 11 months ago (2015-01-27 07:47:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/867883006/1
5 years, 11 months ago (2015-01-27 07:48:40 UTC) #2
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch ...
5 years, 11 months ago (2015-01-27 07:49:01 UTC) #4
dconnelly
On 2015/01/27 07:49:01, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
5 years, 11 months ago (2015-01-27 11:50:00 UTC) #6
Tom Finegan
5 years, 11 months ago (2015-01-27 22:47:20 UTC) #7
On 2015/01/27 11:50:00, dconnelly wrote:
> On 2015/01/27 07:49:01, I haz the power (commit-bot) wrote:
> > Failed to apply patch for DEPS:
> > While running git apply --index -3 -p1;
> >   error: patch failed: DEPS:40
> >   error: repository lacks the necessary blob to fall back on 3-way merge.
> >   error: DEPS: patch does not apply
> > 
> > Patch:       DEPS
> > Index: DEPS
> > diff --git a/DEPS b/DEPS
> > index
> >
>
87212e663ff67884d2f7de30169c261a12bf663e..7e2f58f9973fdaa37c202c9e042637254ce3d0d0
> > 100644
> > --- a/DEPS
> > +++ b/DEPS
> > @@ -40,7 +40,7 @@
> >    'pdfium_git': 'https://pdfium.googlesource.com',
> >    'skia_git': 'https://skia.googlesource.com',
> >    'boringssl_git': 'https://boringssl.googlesource.com',
> > -  'libvpx_revision': '5da40ca3395cd09443f3d4a3f8b86e495a6df364',
> > +  'libvpx_revision': 'cc9c0c5198e416173f480fb1f11e052f5c29a95b',
> >    'sfntly_revision': '1bdaae8fc788a5ac8936d68bf24f37d977a13dac',
> >    'skia_revision': '1d124c3142acf1a678de9c3f3189bf0c56d32a39',
> >    # Three lines of non-changing comments so that
> 
> This failed due to merge conflict. I'm reverting manually here:
> https://codereview.chromium.org/882483006/

lgtm for tbr

Powered by Google App Engine
This is Rietveld 408576698