Replaces instances of the deprecated TimeTicks::HighResNow() with TimeTicks::Now().

Replaces instances of the deprecated TimeTicks::HighResNow() with TimeTicks::Now().

BUG=

Committed: https://crrev.com/3be83970173f29ff3fec067fe64ff9910ce53c73
Cr-Commit-Position: refs/heads/master@{#313084}

[charliea_google.com, 2015-01-21 23:16:14]

Patchset #1 (id:1) has been deleted

[charliea_google.com, 2015-01-21 23:16:23]

Patchset #1 (id:20001) has been deleted

[charliea_google.com, 2015-01-21 23:16:30]

Patchset #1 (id:40001) has been deleted

[charliea_google.com, 2015-01-21 23:16:37]

Patchset #1 (id:60001) has been deleted

[charliea_google.com, 2015-01-21 23:16:45]

Patchset #1 (id:80001) has been deleted

[charliea_google.com, 2015-01-21 23:21:29]

charliea@google.com changed reviewers:
+ miu@chromium.org

[charliea_google.com, 2015-01-21 23:21:30]

Hi Yuri,

After you LGTM these changes, I'll send the review to someone with sufficient
readability to submit the changelist.

[charliea_google.com, 2015-01-21 23:31:12]

Patchset #2 (id:120001) has been deleted

[miu, 2015-01-21 23:52:51]

Thanks for taking care of this.  I also recommend deleting the HighResNow() and
IsHighResNowFastAndReliable() methods in the base::TimeTicks class declaration. 
This will let the compiler tell you whether you got them all.

Other comments:

https://codereview.chromium.org/864943002/diff/100001/base/debug/trace_event_...
File base/debug/trace_event_unittest.cc (right):

https://codereview.chromium.org/864943002/diff/100001/base/debug/trace_event_...
base/debug/trace_event_unittest.cc:875: base::TimeTicks end_time =
base::TimeTicks::Now() + elapsed;
This is identical to the PlatformThread::Sleep() implementation for all the
platforms.  Thus, I suggest deleting this function.  Then, you can also delete
trace_event_unittest.h.

https://codereview.chromium.org/864943002/diff/100001/cc/scheduler/delay_base...
File cc/scheduler/delay_based_time_source.h (right):

https://codereview.chromium.org/864943002/diff/100001/cc/scheduler/delay_base...
cc/scheduler/delay_based_time_source.h:98: // DelayBasedTimeSource uses
base::TimeTicks::Now as its timebase.
This change has caused a weird situation.  The behavior of this class is now
equivalent to DelayBasedTimeSource (declared above).  I would change this
comment to:

// DelayBasedTimeSource that once used base::TimeTicks::HighResNow as its
// time source, but is now a no-op.
// TODO(brianderson): Remove along with gfx::FrameTime.  http://crbug.com/447329

https://codereview.chromium.org/864943002/diff/100001/content/renderer/render...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/864943002/diff/100001/content/renderer/render...
content/renderer/render_widget.cc:1063: if
(base::TimeTicks::IsHighResNowFastAndReliable())
Consider replacing all occurrences of IsHighResNowFastAndReliable with
IsHighResolution.  IIRC, this is only used in a few files so it shouldn't be a
huge addition to this CL.

https://codereview.chromium.org/864943002/diff/100001/content/renderer/render...
content/renderer/render_widget.cc:1168: // If we don't have a fast and accurate
HighResNow, we assume the input
You should also remove references to HighResNow in comments.  Suggest you `git
grep HighResNow` to identify all LOC.  Hopefully, not too many extra files need
to be touched.

https://codereview.chromium.org/864943002/diff/100001/ui/views/win/hwnd_messa...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/864943002/diff/100001/ui/views/win/hwnd_messa...
ui/views/win/hwnd_message_handler.cc:2432: now = base::TimeTicks::Now();
nit/clean-up: Remove the declaration (3 lines above) and make this line:

  const base::TimeTicks now = base::TimeTicks::Now();

[charliea_google.com, 2015-01-22 15:20:46]

PTAL. Especially with the comment changes, there were some judgement calls
involved.

https://codereview.chromium.org/864943002/diff/100001/base/debug/trace_event_...
File base/debug/trace_event_unittest.cc (right):

https://codereview.chromium.org/864943002/diff/100001/base/debug/trace_event_...
base/debug/trace_event_unittest.cc:875: base::TimeTicks end_time =
base::TimeTicks::Now() + elapsed;
On 2015/01/21 23:52:51, miu wrote:
> This is identical to the PlatformThread::Sleep() implementation for all the
> platforms.  Thus, I suggest deleting this function.  Then, you can also delete
> trace_event_unittest.h.

Done.

https://codereview.chromium.org/864943002/diff/100001/cc/scheduler/delay_base...
File cc/scheduler/delay_based_time_source.h (right):

https://codereview.chromium.org/864943002/diff/100001/cc/scheduler/delay_base...
cc/scheduler/delay_based_time_source.h:98: // DelayBasedTimeSource uses
base::TimeTicks::Now as its timebase.
On 2015/01/21 23:52:51, miu wrote:
> This change has caused a weird situation.  The behavior of this class is now
> equivalent to DelayBasedTimeSource (declared above).  I would change this
> comment to:
> 
> // DelayBasedTimeSource that once used base::TimeTicks::HighResNow as its
> // time source, but is now a no-op.
> // TODO(brianderson): Remove along with gfx::FrameTime. 
http://crbug.com/447329

Done.

https://codereview.chromium.org/864943002/diff/100001/content/renderer/render...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/864943002/diff/100001/content/renderer/render...
content/renderer/render_widget.cc:1063: if
(base::TimeTicks::IsHighResNowFastAndReliable())
On 2015/01/21 23:52:51, miu wrote:
> Consider replacing all occurrences of IsHighResNowFastAndReliable with
> IsHighResolution.  IIRC, this is only used in a few files so it shouldn't be a
> huge addition to this CL.

Done.

https://codereview.chromium.org/864943002/diff/100001/content/renderer/render...
content/renderer/render_widget.cc:1168: // If we don't have a fast and accurate
HighResNow, we assume the input
On 2015/01/21 23:52:51, miu wrote:
> You should also remove references to HighResNow in comments.  Suggest you `git
> grep HighResNow` to identify all LOC.  Hopefully, not too many extra files
need
> to be touched.

Done.

https://codereview.chromium.org/864943002/diff/100001/ui/views/win/hwnd_messa...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/864943002/diff/100001/ui/views/win/hwnd_messa...
ui/views/win/hwnd_message_handler.cc:2432: now = base::TimeTicks::Now();
On 2015/01/21 23:52:51, miu wrote:
> nit/clean-up: Remove the declaration (3 lines above) and make this line:
> 
>   const base::TimeTicks now = base::TimeTicks::Now();

Done.

[miu, 2015-01-22 20:06:42]

lgtm % these two things:

https://codereview.chromium.org/864943002/diff/140001/base/debug/trace_event_...
File base/debug/trace_event_unittest.h (left):

https://codereview.chromium.org/864943002/diff/140001/base/debug/trace_event_...
base/debug/trace_event_unittest.h:1: // Copyright (c) 2012 The Chromium Authors.
All rights reserved.
Don't forget to remove this from the .gyp and BUILD.gn files.

https://codereview.chromium.org/864943002/diff/140001/tools/valgrind/gtest_ex...
File tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt (right):

https://codereview.chromium.org/864943002/diff/140001/tools/valgrind/gtest_ex...
tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt:6: TimeTicks.Now
Actually, you should should just remove the line.  I think the "slowdown" was
referring to the old implementation, which could provide an expensive yet
reliable HighResNow() impl.

[charliea_google.com, 2015-01-22 22:56:58]

charliea@google.com changed reviewers:
+ darin@chromium.org

[charliea_google.com, 2015-01-22 22:56:59]

Now that I have an LGTM from miu - darin, could you take a look at this (for
readability purposes)?

https://codereview.chromium.org/864943002/diff/140001/base/debug/trace_event_...
File base/debug/trace_event_unittest.h (left):

https://codereview.chromium.org/864943002/diff/140001/base/debug/trace_event_...
base/debug/trace_event_unittest.h:1: // Copyright (c) 2012 The Chromium Authors.
All rights reserved.
On 2015/01/22 20:06:42, miu wrote:
> Don't forget to remove this from the .gyp and BUILD.gn files.

Done.

https://codereview.chromium.org/864943002/diff/140001/tools/valgrind/gtest_ex...
File tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt (right):

https://codereview.chromium.org/864943002/diff/140001/tools/valgrind/gtest_ex...
tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt:6: TimeTicks.Now
On 2015/01/22 20:06:42, miu wrote:
> Actually, you should should just remove the line.  I think the "slowdown" was
> referring to the old implementation, which could provide an expensive yet
> reliable HighResNow() impl.

Done.

[charliea_google.com, 2015-01-23 17:19:47]

On 2015/01/22 22:56:59, charliea wrote:
> Now that I have an LGTM from miu - darin, could you take a look at this (for
> readability purposes)?

s/readability/ownership

[charliea_google.com, 2015-01-23 18:09:47]

charliea@google.com changed reviewers:
- darin@chromium.org

[charliea_google.com, 2015-01-23 18:21:30]

charliea@google.com changed reviewers:
+ jam@chromium.org

[jam, 2015-01-23 18:25:16]

lgtm

[charliea_google.com, 2015-01-23 18:27:35]

The CQ bit was checked by charliea@google.com

[commit-bot: I haz the power, 2015-01-23 18:29:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864943002/160001

[commit-bot: I haz the power, 2015-01-23 18:38:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 18:38:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[charliea_google.com, 2015-01-23 18:52:00]

charliea@google.com changed reviewers:
+ asvitkine@google.com

[Alexei Svitkine (slow), 2015-01-23 20:53:11]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org
- asvitkine@google.com

[Alexei Svitkine (slow), 2015-01-23 20:53:12]

LGTM

[charliea_google.com, 2015-01-23 20:55:41]

The CQ bit was checked by charliea@google.com

[commit-bot: I haz the power, 2015-01-23 20:57:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864943002/160001

[commit-bot: I haz the power, 2015-01-23 20:57:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 20:57:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[charliea_google.com, 2015-01-26 17:33:29]

The CQ bit was checked by charliea@google.com

[commit-bot: I haz the power, 2015-01-26 17:34:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864943002/160001

[commit-bot: I haz the power, 2015-01-26 17:36:19]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2015-01-26 17:37:21]

Patchset 3 (id:??) landed as
https://crrev.com/3be83970173f29ff3fec067fe64ff9910ce53c73
Cr-Commit-Position: refs/heads/master@{#313084}