tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt - Issue 864943002: Replaces instances of the deprecated TimeTicks::HighResNow() with TimeTicks::Now().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt

Issue 864943002: Replaces instances of the deprecated TimeTicks::HighResNow() with TimeTicks::Now(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made changes based on review comments (including deleting IsHighResNowFastAndReliable) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Too slow under Valgrind/Wine and TSan/Windows	1 # Too slow under Valgrind/Wine and TSan/Windows

2 TimeTicks.WinRollover	2 TimeTicks.WinRollover

3	3

4 # Very sensitive to slowdown	4 # Very sensitive to slowdown

5 TimeTicks.Deltas	5 TimeTicks.Deltas

6 TimeTicks.HighResNow	6 TimeTicks.Now
	miu 2015/01/22 20:06:42 Actually, you should should just remove the line. Actually, you should should just remove the line. I think the "slowdown" was referring to the old implementation, which could provide an expensive yet reliable HighResNow() impl. charliea_google.com 2015/01/22 22:56:58 Done. Show quoted text On 2015/01/22 20:06:42, miu wrote: > Actually, you should should just remove the line. I think the "slowdown" was > referring to the old implementation, which could provide an expensive yet > reliable HighResNow() impl. Done.
7 TimerTest.RepeatingTimer*	7 TimerTest.RepeatingTimer*

8	8

9 # This Windows-native sampling profiler test does not work under our tools	9 # This Windows-native sampling profiler test does not work under our tools

10 # because it assumes the original code runs, not the modified version	10 # because it assumes the original code runs, not the modified version

11 # with instrumentation. See http://crbug.com/106829	11 # with instrumentation. See http://crbug.com/106829

12 SamplingProfilerTest.Sample	12 SamplingProfilerTest.Sample

OLD	NEW

« base/debug/trace_event_unittest.h ('K') | « tools/metrics/histograms/histograms.xml ('k') | ui/compositor/layer_animator.cc » ('j') | no next file with comments »