[PATCH 6/11] ozone: evdev: Factor device I/O out of EventFactoryOzone

ozone: evdev: Factor device I/O out of EventFactoryOzone

This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.

This splits EventFactoryOzone into two parts: EventFactoryOzone and
InputDeviceFactoryOzone. The new InputDeviceFactoryOzone class is now the
device I/O-centric part, and is intended to exist on a low-latency thread.

Hotplug events still originate on the UI thread, but this is not a
problem because hotplug is not latency critical. We're sharing udev
with the display code, so its easiest leave that code alone for now.

This doesn't add a new thread yet. Everything still runs on the UI thread.

BUG=449710
TEST=boot link_freon & move mouse

Committed: https://crrev.com/5957ed6506d28c8310657416f728efdb93dea482
Cr-Commit-Position: refs/heads/master@{#313629}

[spang, 2015-01-23 21:58:59]

spang@chromium.org changed reviewers:
+ alexst@chromium.org

[alexst (slow to review), 2015-01-27 19:31:41]

lgtm with nits

https://codereview.chromium.org/863353003/diff/20001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_factory_evdev.h (right):

https://codereview.chromium.org/863353003/diff/20001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_factory_evdev.h:100: // Factory for per-device
objects.
We should add threading notes here.

https://codereview.chromium.org/863353003/diff/20001/ui/events/ozone/evdev/in...
File ui/events/ozone/evdev/input_controller_evdev.cc (right):

https://codereview.chromium.org/863353003/diff/20001/ui/events/ozone/evdev/in...
ui/events/ozone/evdev/input_controller_evdev.cc:129:
input_device_factory_->DisableInternalKeyboardExceptKeys(
nit: I prefer a set of curly braces once it becomes multiline statement, even if
due to formatting.

[spang, 2015-01-27 20:25:21]

https://codereview.chromium.org/863353003/diff/20001/ui/events/ozone/evdev/in...
File ui/events/ozone/evdev/input_device_factory_evdev.cc (right):

https://codereview.chromium.org/863353003/diff/20001/ui/events/ozone/evdev/in...
ui/events/ozone/evdev/input_device_factory_evdev.cc:169:
gesture_property_provider_(new GesturePropertyProvider),
Oops.

[alexst (slow to review), 2015-01-27 20:26:18]

https://codereview.chromium.org/863353003/diff/20001/ui/events/ozone/evdev/in...
File ui/events/ozone/evdev/input_device_factory_evdev.cc (right):

https://codereview.chromium.org/863353003/diff/20001/ui/events/ozone/evdev/in...
ui/events/ozone/evdev/input_device_factory_evdev.cc:169:
gesture_property_provider_(new GesturePropertyProvider),
On 2015/01/27 20:25:21, spang wrote:
> Oops.

Noted in patch 7.

[spang, 2015-01-28 01:40:46]

https://codereview.chromium.org/863353003/diff/20001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_factory_evdev.h (right):

https://codereview.chromium.org/863353003/diff/20001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_factory_evdev.h:100: // Factory for per-device
objects.
On 2015/01/27 19:31:41, alexst wrote:
> We should add threading notes here.

Will add the comment to #10, which introduces the proxy object here.

https://codereview.chromium.org/863353003/diff/20001/ui/events/ozone/evdev/in...
File ui/events/ozone/evdev/input_controller_evdev.cc (right):

https://codereview.chromium.org/863353003/diff/20001/ui/events/ozone/evdev/in...
ui/events/ozone/evdev/input_controller_evdev.cc:129:
input_device_factory_->DisableInternalKeyboardExceptKeys(
On 2015/01/27 19:31:41, alexst wrote:
> nit: I prefer a set of curly braces once it becomes multiline statement, even
if
> due to formatting.

Done.

[spang, 2015-01-28 20:51:56]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2015-01-28 20:52:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/863353003/60001

[commit-bot: I haz the power, 2015-01-28 20:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-28 20:55:47]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[alexst (slow to review), 2015-01-28 21:00:03]

The CQ bit was checked by alexst@chromium.org

[commit-bot: I haz the power, 2015-01-28 21:00:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/863353003/60001

[commit-bot: I haz the power, 2015-01-28 21:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-28 21:04:03]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alexst (slow to review), 2015-01-28 21:23:33]

The CQ bit was checked by alexst@chromium.org

[commit-bot: I haz the power, 2015-01-28 21:24:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/863353003/60001

[commit-bot: I haz the power, 2015-01-28 21:27:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-28 21:27:36]

Try jobs failed on following builders:
  ios_rel_device_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)

[spang, 2015-01-28 21:35:31]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2015-01-28 21:36:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/863353003/60001

[commit-bot: I haz the power, 2015-01-28 21:39:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-28 21:39:39]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)

[spang, 2015-01-28 23:09:45]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2015-01-28 23:11:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/863353003/100001

[commit-bot: I haz the power, 2015-01-29 00:05:31]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-01-29 00:06:39]

Patchset 6 (id:??) landed as
https://crrev.com/5957ed6506d28c8310657416f728efdb93dea482
Cr-Commit-Position: refs/heads/master@{#313629}